Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs fixing #1

Merged
merged 4 commits into from
Mar 10, 2023
Merged

Bugs fixing #1

merged 4 commits into from
Mar 10, 2023

Conversation

siriuslatte
Copy link
Contributor

@siriuslatte siriuslatte commented Mar 8, 2023

Some bugs pointed out (or not intended functionality at all) were:

Starting from this Scribe's Script:

actor BEATRIZ $beatriz_id # Environment accessors won't halt the execution anymore

interact BEATRIZ {
    echo "Hello, world!"
}
const Runtime = Scribe.load("...", {
    beatriz_id: "erfrbh"
})

Runtime.start(); // Normal execution of Scribe

{
    Runtime.interact("IDENTIFIER"); // It was meant to be the identifier id which is retrieved from evaluating the expression, such as below.

    Runtime.interact("erfrbh") // Intended behavior

    // Also calling multiple consecutive times an interaction would cause a 
    Runtime.interact("...")
    Runtime.interact("...")
    Runtime.interact("...")
    Runtime.interact("...")
    Runtime.interact("...") // Shouldn't error anymore
}

@siriuslatte siriuslatte added bug Something wasn't working, fixed enhancement New feature or request labels Mar 8, 2023
@siriuslatte siriuslatte self-assigned this Mar 8, 2023
@siriuslatte
Copy link
Contributor Author

There was some issues with default scenes and scenes in general, fixed those and now Scribe should be ready for a testing phase.

Copy link
Contributor

@RigidStudios RigidStudios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RigidStudios RigidStudios merged commit d6773b5 into main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something wasn't working, fixed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants