add option to verify certs for http requests #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
|
|
||
| def init_poolmanager(self, *args, **kwargs): | ||
| super(BobaPKIHTTPAdapter, self).init_poolmanager(assert_hostname=False, *args, **kwargs) |
There was a problem hiding this comment.
FYI this will break if this is called with assert_hostname=<asd> - do you want to pop it out of kwargs?
There was a problem hiding this comment.
this what our ATT code is doing so it's prolly fine but yeah I can pop it out too
| cert_verify = os.environ.get('BOBAPKI_CACERT_VERIFY', None) | ||
| if cert_verify is not None: | ||
| session.mount('https://', BobaPKIHTTPAdapter()) | ||
| session.verify = cert_verify |
There was a problem hiding this comment.
Is this supposed to be a bool? a string with true/false? if it's false then the if check will return true still.
There was a problem hiding this comment.
it can be a string or boolean; but yeah we are passing a string here which is a path to the cert file
| @@ -54,7 +54,7 @@ def get_static_files(path): | |||
|
|
|||
| setup( | |||
| name='luigi', | |||
| version='2.7.5.affirm.1.4.0', | |||
| version='2.7.5+affirm.1.4.2', | |||
There was a problem hiding this comment.
yeah I messed up and accidentally created this pypi package already :(
avenkatraman
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.