Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): avatar profiles color #2230

Conversation

ashrafchowdury
Copy link
Collaborator

@ashrafchowdury ashrafchowdury commented Nov 8, 2024

Description

This PR aims to fix the avatar profile color issue by updating it according to our new color schema.

To avoid repeating the same code again and again I extended the Ant-design Avatar component and modified it so that we don't have to repeat the same code again.

Related Issue

Closes AGE-639

Related PRs

Changes will be reflected in

  • Sidebar user profile component
  • Settings workspace page
  • PostSignup page
  • Evaluation comparison page

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 8, 2024
Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 6:11am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 6:11am

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashrafchowdury

I tested the PR in beta. I am not sure what changes are expected, if you can please attach some screenshots. I saw that you have modified the colors in the evaluation comparison view but I don't see any change there.

CleanShot 2024-11-10 at 18 16 19@2x

@bekossy can you please review the code

@ashrafchowdury
Copy link
Collaborator Author

@mmabrouk Changes will be reflected in two places: 1. on the Workspace page, and 2. on the evaluation comparison page.

Screenshot_7-11-2024_221151_localhost

@mmabrouk
Copy link
Member

Thanks @ashrafchowdury
I saw the changes in the workspace page, however in the eval page I did not see any changes (see my screenshot), can you please share what you see there

@mmabrouk
Copy link
Member

@ashrafchowdury I have reservations on the kind of people you are inviting to Agenta :P

@ashrafchowdury
Copy link
Collaborator Author

Thanks @ashrafchowdury I saw the changes in the workspace page, however in the eval page I did not see any changes (see my screenshot), can you please share what you see there

Apologies for the confusion. The changes in the evaluation comparison are minimal, merely adjusting the tags' color slightly, making it barely noticeable. The modifications were implemented to avoid code repetition, that’s all.

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashrafchowdury !

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2024
@mmabrouk mmabrouk changed the base branch from main to feature/observability-checkpoint-2 November 11, 2024 12:34
@mmabrouk mmabrouk merged commit 6f9a69f into feature/observability-checkpoint-2 Nov 11, 2024
9 checks passed
@mmabrouk mmabrouk deleted the AGE-639/change-avatar-profile-color-core branch November 11, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
antd Frontend lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants