-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): avatar profiles color #2230
fix(frontend): avatar profiles color #2230
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…39/change-avatar-profile-color-core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ashrafchowdury
I tested the PR in beta. I am not sure what changes are expected, if you can please attach some screenshots. I saw that you have modified the colors in the evaluation comparison view but I don't see any change there.
@bekossy can you please review the code
@mmabrouk Changes will be reflected in two places: 1. on the Workspace page, and 2. on the evaluation comparison page. |
Thanks @ashrafchowdury |
@ashrafchowdury I have reservations on the kind of people you are inviting to Agenta :P |
Apologies for the confusion. The changes in the evaluation comparison are minimal, merely adjusting the tags' color slightly, making it barely noticeable. The modifications were implemented to avoid code repetition, that’s all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ashrafchowdury !
Description
This PR aims to fix the avatar profile color issue by updating it according to our new color schema.
To avoid repeating the same code again and again I extended the Ant-design Avatar component and modified it so that we don't have to repeat the same code again.
Related Issue
Closes AGE-639
Related PRs
Changes will be reflected in