#114553545 Merging Coverall Test Results

[fighterii]

https://www.pivotaltracker.com/story/show/114553545

Rakefile task added, .simplecov for options added, modified env.rb and rails_helper.rb

By modifiying the .simplecov file with additional "add_filter" methods we can specify which files should not be tested (regarding to the second point of the story, that we only want to test files within the app folder)

[fighterii]

@tochman : When you want to merge this in, you have to change the Semaphore task to:
bundle exec rake test_with_coveralls

(in contrast to the failing bundle exec rake :test_with_coveralls with a doublepoint, from PR#44)

[fighterii]

However, i noticed a significant drop in coverage.

Because the blank lines and "end" lines are counted as relevant lines.

This is an issue of SimpleCov Issue #444

I tried the suggested fix with changing line 7 of the merge_helpers.rb of the SimpleCov lib locally and got the following improvements:

As you can see, unrelevant lines are now correctly displayed in grey and not counted as uncovered:

[tochman]

Hmm.. I see. Weird. Are the cucumber tests taken into consideration in the above coverage calculations?

[fighterii]

Let me check this again..

[fighterii]

Weird. It seems like this are only the cucumber scores.

I tested this behavior by changing the test_with_coverall task

For task :test_with_coveralls => [:spec, :cucumber, 'coveralls:push'] i get the scores from above (58.95%)

For only rspec (task :test_with_coveralls => [:spec, 'coveralls:push']) i get 0.0% coverage.

For only cucumber (task :test_with_coveralls => [:cucumber, 'coveralls:push']) i get the scores as in the combined tests (58.95%)

[fighterii]

@tochman : Seems its working (at least locally) now.
I get test coverage of ~90%.

Maybe we could test this within the CI now by changing the Semaphore task to:
bundle exec rake test_with_coveralls

The problem was, that SimpleCov needs to know which spec files belong to which "group" of testing.
So we have to add SimpleCov.command_name 'test:xyz' to ONE file of each Rspec folder.
I chosed the two user_spec.rb in models and requests\api\v1

[tochman]

I'll merge this in if you feel it's ready to be tested on semaphore.

[fighterii]

I think this should work now :)