chore: fix the lint, and fail faster for lint

.github/workflows/lint.yml

@@ -0,0 +1,39 @@
+name: Lint check
+
+# run CI on pushes to master, and on all PRs (even the ones that target other
+# branches)
+
+on:
+ push:
+   branches: [master]
+ pull_request:
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v1
+    - uses: actions/setup-node@v1
+      with:
+        node-version: '12.16.1'
+
+    # FIXME: Reenable after 2020-04-01 when Github cache doesn't take forever.
+    #- name: cache node modules
+    #  uses: actions/cache@v1
+    #  with:
+    #    path: ~/.cache/yarn
+    #    key: ${{ runner.os }}-yarn-${{ hashFiles('yarn.lock') }}
+    #    restore-keys: |
+    #      ${{ runner.os }}-yarn-
+
+    # 'yarn install' must be done at the top level, to build all the
+    # cross-package symlinks
+    - name: yarn install
+      run: yarn install
+    # 'yarn build' loops over all workspaces
+    - name: yarn build
+      run: yarn build
+
+    # 'yarn lint-check' just checks the lint where desired
+    - name: lint check
+      run: yarn lint-check

.github/workflows/test-all-packages.yml

@@ -120,6 +120,3 @@ jobs:
       run: cd packages/weak-store && yarn test
     - name: yarn test (zoe)
       run: cd packages/zoe && yarn test
-
-    - name: lint check
-      run: yarn lint-check

packages/cosmic-swingset/lib/ag-solo/fake-chain.js

@@ -42,9 +42,9 @@ export async function connectToFakeChain(basedir, GCI, role, delay, inbound) {
   const vatsdir = path.join(basedir, 'vats');
   const argv = [`--role=${role}`, bootAddress];
   const stateDBdir = path.join(basedir, `fake-chain-${GCI}-state`);
-  function doOutboundBridge(dstID, obj) {
+  function doOutboundBridge(dstID, _obj) {
     // console.error('received', dstID, obj);
-    return 'IBC and bridge device not used on fake-chain';
+    return `Bridge device (${dstID}) not implemented for fake-chain`;
   }
   function flushChainSends(replay) {
     if (replay) {