Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multichain Testing - support go-relayer #10179

Closed
0xpatrickdev opened this issue Oct 1, 2024 · 2 comments · Fixed by #10182
Closed

Multichain Testing - support go-relayer #10179

0xpatrickdev opened this issue Oct 1, 2024 · 2 comments · Fixed by #10182
Assignees
@0xpatrickdev
Labels
enhancement New feature or request

Comments

@0xpatrickdev
Copy link
Member

0xpatrickdev commented Oct 1, 2024 •
edited by turadg
Loading

What is the Problem Being Solved?

Some of the chains in the Fast USDC product requirements depend on go-relayer.

(Cosmos SDK ecosystem has different relayer clients. They're all supposed to implement the same spec but they may have deviations. )

multichain-testing only runs with hermes relayers. We should confirm it also works with go-relayer.

Description of the Design

Run test suite with both hermes and go-relayer in parallel in CI.

Security Considerations

Scaling Considerations

Test Plan

Dispatch job, not automatic on every PR

Upgrade Considerations
@0xpatrickdev 0xpatrickdev added the enhancement New feature or request label Oct 1, 2024
@0xpatrickdev 0xpatrickdev changed the title Multichain Testing - support go-relayer Multichain Testing - support go-relayer Oct 1, 2024
@0xpatrickdev 0xpatrickdev self-assigned this Oct 1, 2024
@0xpatrickdev 0xpatrickdev mentioned this issue Oct 2, 2024
Merged
@aj-agoric
Copy link

Added to no release needed per agreement with @turadg during today's grooming.

@0xpatrickdev
Copy link
Member Author

0xpatrickdev commented Nov 1, 2024 •
edited
Loading

One-off tests with go-relayer are successful, confirming Orch API is compatible with both Hermes and Go Relayer.

There've been some hiccups getting this into CI - the go-relayer does not seem to reliably start in the Starship environment. I owe some links to failing CI runs with the symptoms.

@mergify mergify bot closed this as completed in #10182 Jan 17, 2025
mergify bot added a commit that referenced this issue Jan 17, 2025
@mergify
ci: multichain-testing with go-relayer (#10182)
fdc566c 
closes: #10179

## Description

Ensures compatibility with [go-relayer](https://github.com/cosmos/relayer) by adding workflow dispatch jobs to `multichain-e2e` for Orchestration API (`config.go-relayer.yaml`) and FastUSDC (`config.fusdc.go-relayer.yaml`). Our existing tests using [hermes](https://github.com/informalsystems/hermes). Scope is mainly for the Orchestration API, but `x/vibc` is also covered to an extent.

Towards this goal:
- enable starship faucet for agoric in all configs (required for `go-relayer`)
- update channel-close tests to use `go-relayer` when `RELAYER_TYPE` env var is present

### Security Considerations
n/a, test code

### Scaling Considerations
Not currently part of integration tests that run on merges to master. 

### Documentation Considerations
Added a section in the `README.md` with instructions for running the tests with `go-relayer`.

### Testing Considerations
Runs existing test suite against `go-relayer`, extending our test coverage across to the two main `cosmos-sdk` relayer clients. This should help identify any relayer-specific issues or discrepancies. Please note: these tests will not run on every PR and must be dispatched manually.

### Upgrade Considerations
n/a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xpatrickdev 0xpatrickdev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: multichain-testing with go-relayer Agoric/agoric-sdk
2 participants
@0xpatrickdev @aj-agoric