Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ability to withdraw from Contract Fee account #10700

Closed
turadg opened this issue Dec 16, 2024 · 0 comments · Fixed by #10815
Closed

ability to withdraw from Contract Fee account #10700

turadg opened this issue Dec 16, 2024 · 0 comments · Fixed by #10815
Assignees
@dckc
Labels
enhancement New feature or request
Milestone
FU4: UI integration

Comments

@turadg
Copy link
Member

turadg commented Dec 16, 2024 •
edited
Loading

What is the Problem Being Solved?

Before release there must be a way to withdraw fees that have been collected

Description of the Design

From Product,

Contract fees should go to a new vbank account which is the orchestration fee account that is only accessible to the core eval.

Security Considerations

Scaling Considerations

Test Plan

Unit, bootstrap and A3P multichain functional tests

Upgrade Considerations
@turadg turadg added the enhancement New feature or request label Dec 16, 2024
@turadg turadg added this to the FU4: UI integration milestone Dec 16, 2024
@dckc dckc mentioned this issue Jan 8, 2025
Merged
6 tasks
@mergify mergify bot closed this as completed in #10815 Jan 15, 2025
mergify bot added a commit that referenced this issue Jan 15, 2025
@mergify
feat(fast-usdc): withdraw and distribute contract fees (#10815)
44f449b 
closes: #10700

## Description

 - creatorFacet method to withdraw fees
   - unit test
 - core eval script to distribute fees
   - bootstrap test
   - refactor: publishDisplayInfo is not specific to fast-usdc

### Security / Scaling Considerations / Upgrade Considerations

straightforward; not yet deployed

### Documentation Considerations

 - [x] builder script has usage docs: `Use: [--fixedFees <number> | --feePortion <percent>] --destinationAddress <address>`
 - ~~document how to use it with cosgov~~

### Testing Considerations

 - [x] contract test: 1 positive, 1 negative
 - [x] bootstrap test for core eval
    - [x] fixed amount
    - [x] portion
 - [x] multichain test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dckc dckc

Labels
enhancement New feature or request
Projects
None yet
Milestone
FU4: UI integration
Development

Successfully merging a pull request may close this issue.

feat(fast-usdc): withdraw and distribute contract fees Agoric/agoric-sdk
2 participants
@turadg @dckc