Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn install changes packages/cosmic-swingset/go.mod #114

Closed
katelynsills opened this issue Dec 3, 2019 · 7 comments · Fixed by #115
Closed

yarn install changes packages/cosmic-swingset/go.mod #114

katelynsills opened this issue Dec 3, 2019 · 7 comments · Fixed by #115
Labels
cosmic-swingset package: cosmic-swingset

Comments

@katelynsills
Copy link
Contributor

Screen Shot 2019-12-02 at 3 59 54 PM

PR to follow
@katelynsills katelynsills mentioned this issue Dec 3, 2019
Merged
@warner warner added the cosmic-swingset package: cosmic-swingset label Dec 4, 2019
dckc pushed a commit to dckc/agoric-sdk that referenced this issue Dec 5, 2019
@katelynsills
Move PixelList Logic into Strategy (Agoric#114)
38e3598 
* move the pixel list logic into the strategy
dckc pushed a commit to dckc/agoric-sdk that referenced this issue Dec 5, 2019
@michaelfig
fix(http): walk the registeredHandlers backward properly
157b9ad 
Closes Agoric#114
@erights
Copy link
Member

erights commented Dec 11, 2019

I'm still seeing this. Should I reopen?

@erights
Copy link
Member

erights commented Dec 11, 2019

Actually I'm seeing the opposite: that line is being added. Reopening.

@erights erights reopened this Dec 11, 2019
@katelynsills
Copy link
Contributor Author

What version of Go do you have?

@erights
Copy link
Member

erights commented Dec 11, 2019

go version go1.12.6 darwin/amd64

@michaelfig
Copy link
Member

Although 1.12 will work to compile, it adds the appengine dependency while 1.13+ removes it. They're incompatible in this tiny regard.

@warner
Copy link
Member

warner commented Dec 13, 2019

Ok, so is the resolution to require Go 1.13? Should we update the README?

@warner warner reopened this Dec 13, 2019
@katelynsills
Copy link
Contributor Author

Yeah, it's probably a good idea to recommend Go 1.13. It's not a strict requirement as long as they remember not to check in their changes to go.mod but maybe that's too complicated for people

warner added a commit that referenced this issue Dec 13, 2019
@warner
cosmic-swingset/README: recommend Go-1.13 to avoid changing go.mod
ee18983 
closes #114
@warner warner mentioned this issue Dec 13, 2019
Closed
@warner warner closed this as completed in 95ad411 Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cosmic-swingset package: cosmic-swingset
Projects
None yet
Milestone
No milestone
4 participants
@warner @erights @michaelfig @katelynsills