Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the Zoe contract files out of packages/zoe #1656

Open
katelynsills opened this issue Sep 1, 2020 · 5 comments · May be fixed by #7399
Open

Move the Zoe contract files out of packages/zoe #1656

katelynsills opened this issue Sep 1, 2020 · 5 comments · May be fixed by #7399
Assignees
Labels

Comments

@katelynsills
Copy link
Contributor

The Zoe contract files should be in a different package. Zoe is deep, crucial infrastructure. CoveredCall is a cool example.

This will help us test the code coverage of Zoe specifically, versus the contracts.

Having an aggregate package for examples (other than Multipool Autoswap) seems reasonable rather than exploding them into unmotivated individual packages. Separating out individual examples into their own packages can wait.

Chores:
Create a new package, called something like @agoric/sample-contracts (name TBD)
Create a new package specifically for multipool autoswap (name TBD)

@Tartuffo
Copy link
Contributor

Tartuffo commented Feb 3, 2022

@dckc This does not have an area label that is covered by our weekly tech / planning meetings. Can you assign the proper label? We cover: agd, agoric-cosmos, amm, core economy, cosmic-swingset, endo, getrun, governance, installation-bundling, metering, run-protocol, staking, swingset, swingset-runner, token economy, wallet, zoe contract. Or, if this is accurately labeled by an area label we should be covering in one of our weekly meetings, please LMK.

@dckc
Copy link
Member

dckc commented Feb 3, 2022

The Zoe label should fit in the Zoe/ERTP meeting.

@Tartuffo
Copy link
Contributor

Tartuffo commented Feb 3, 2022

Yeah, I realized we do cover "zoe" label in the meeting. Sorry.

@Tartuffo Tartuffo removed the MN-1 label Feb 7, 2022
@Tartuffo
Copy link
Contributor

Tartuffo commented Mar 2, 2022

@dckc Can you please put an estimate on this?

@dckc
Copy link
Member

dckc commented Mar 3, 2022

It's already estimated at 3... that seems about right given risks of unknowns, but I suppose the work that I know needs doing is more of a 2.

@ivanlei ivanlei removed the Beta label Mar 20, 2023
@dckc dckc mentioned this issue May 9, 2023
@dckc dckc linked a pull request Nov 7, 2023 that will close this issue
2 tasks
mergify bot added a commit that referenced this issue Jun 17, 2024
refs: #1656

## Description

Spike on endojs/endo#1656 @kriskowal , similar to https://github.com/Agoric/agoric-sdk/discussions/8416 @dckc 

Makes the core-eval metadata available to `agoric run` so it can report more to the user. cc @michaelfig 

Adds a `--verbose` flag to report:

<img width="687" alt="Screenshot 2024-06-13 at 1 46 28 PM" src="https://github.com/Agoric/agoric-sdk/assets/21505/b76b4d14-2fbd-45c2-b7a5-d94f964f2461">

Also a `scripts/stat-bundle.js` to stat a known bundle path.

### Security Considerations


### Scaling Considerations


### Documentation Considerations


### Testing Considerations


### Upgrade Considerations
mhofman pushed a commit that referenced this issue Jun 20, 2024
refs: #1656

## Description

Spike on endojs/endo#1656 @kriskowal , similar to #8416 @dckc 

Makes the core-eval metadata available to `agoric run` so it can report more to the user. cc @michaelfig 

Adds a `--verbose` flag to report:

<img width="687" alt="Screenshot 2024-06-13 at 1 46 28 PM" src="https://github.com/Agoric/agoric-sdk/assets/21505/b76b4d14-2fbd-45c2-b7a5-d94f964f2461">

Also a `scripts/stat-bundle.js` to stat a known bundle path.

### Security Considerations


### Scaling Considerations


### Documentation Considerations


### Testing Considerations


### Upgrade Considerations
mhofman pushed a commit that referenced this issue Jun 22, 2024
refs: #1656

## Description

Spike on endojs/endo#1656 @kriskowal , similar to #8416 @dckc 

Makes the core-eval metadata available to `agoric run` so it can report more to the user. cc @michaelfig 

Adds a `--verbose` flag to report:

<img width="687" alt="Screenshot 2024-06-13 at 1 46 28 PM" src="https://github.com/Agoric/agoric-sdk/assets/21505/b76b4d14-2fbd-45c2-b7a5-d94f964f2461">

Also a `scripts/stat-bundle.js` to stat a known bundle path.

### Security Considerations


### Scaling Considerations


### Documentation Considerations


### Testing Considerations


### Upgrade Considerations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants