-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rationalize Inter Protocol storage node paths #6111
Comments
See also: And there's perhaps a more general issue of documenting not just the keys but also the data at those keys. Speaking of which... |
In the Jan 23 approach (#6835) to putting vbank assets in chainStorage (#5762), I wonder if we should add a uniqueness constraint on issuerName so that we can key this NameHub on issuerName instead. |
idea: snapshot tests for documentationFor each contract etc. that "owns" part of chainStorage, make a snapshot test with example data. Then index the resulting (inspired by a quick review of p.s. by way of example: https://github.com/Agoric/agoric-sdk/blob/6111-dc-chainStorage-snapshot-idea/packages/vats/test/snapshots/test-agoricNames-rpc-api.js.md |
Taking this general ticket out of Vaults Release. The one important change not to defer is in #7150 |
What is the Problem Being Solved?
They've developed somewhat ad-hoc. For PSM we realized there's more than one PSM (at least one per anchor) and then we realized that even IST may not be fixed: there will someday be another PSM whose mint isn't IST.
This same insight applies to most of Inter Protocol contracts. E.g.
published.vaultFactory
shouldn't assume it's the only vault factory on chain.Description of the Design
Namespace under IST or something similar.
Design naming scheme going out to MN-3 permissionless.
Doc for naming of keys too. Cover this case #5393 (comment)
If keys are an index of high cardinality, they should be under their own parent key so that they don't make siblings of other types hard to find. E.g. if
manager102
sibling tometrics
is bad because the latter will be easy to miss.managers
sibling tometrics
is good.Security Considerations
First to claim gets the path.
Test Plan
The text was updated successfully, but these errors were encountered: