feat(vats): share Invitation issuer/brand in agoricNames #6835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Jan 23, 2023
samsiegart
approved these changes
Jan 24, 2023
dckc
force-pushed
the
dc-invite-brand-rpc
branch
from
fcc5027 to
819ed35
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #6807, #5762
Description
With #5762 , we no longer need to look at an individual wallet to get vbank brands and displayInfo.
This PR does likewise for the Zoe invitation brand (and issuer).
Documentation Considerations
Whatever docs we have for the contents of
agoricNames.brandshould get updated.Testing Considerations
I presume the code that depends on this will test it sufficiently.