Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosmic-swingset: fall back to SimpleStore if LMDB doesn't work #953

Closed
warner opened this issue Apr 17, 2020 · 2 comments
Closed

cosmic-swingset: fall back to SimpleStore if LMDB doesn't work #953

warner opened this issue Apr 17, 2020 · 2 comments
Assignees
@warner
Labels
cosmic-swingset package: cosmic-swingset

Comments

@warner
Copy link
Member

warner commented Apr 17, 2020

Until we get #950 fixed, we need a way to turn off the use of LMDB, so folks running under WSL (Windows Subsystem for Linux), or whatever the root cause turns out to be, can get it to work at all.

This is currently controlled by the import that we use, but for this purpose we need to add a --db= runtime flag of some sort.

cc @FUDCo @dtribble
@warner warner added the cosmic-swingset package: cosmic-swingset label Apr 17, 2020
@warner warner self-assigned this Apr 17, 2020
warner added a commit that referenced this issue Apr 17, 2020
@warner
feat: swing-store-lmdb: add isSwingStore() query
23bf93f 
refs #953
warner added a commit that referenced this issue Apr 17, 2020
@warner
feat: swing-store-simple: add isSwingStore() query
b951483 
refs #953
warner added a commit that referenced this issue Apr 17, 2020
@warner
feat: swing-store-lmdb: add isSwingStore() query
0b94ecc 
refs #953
warner added a commit that referenced this issue Apr 17, 2020
@warner
feat: swing-store-simple: add isSwingStore() query
17b93f6 
refs #953
warner added a commit that referenced this issue Apr 18, 2020
@warner
feat: swing-store-lmdb: add isSwingStore() query
fce7168 
refs #953
warner added a commit that referenced this issue Apr 18, 2020
@warner
feat: swing-store-simple: add isSwingStore() query
c450459 
refs #953
@warner
Copy link
Member Author

warner commented Apr 18, 2020

Today we decided that instead of a --db= argv flag, this should attempt to open a scratch LMDB instance at startup, check to see if that succeeded or failed, delete it, and then proceed with LMDB or Simple depending upon the result.

@warner warner changed the title add switch to control which DB to use in cosmic-swingset cosmic-swingset: fall back to SimpleStore if LMDB doesn't work Apr 18, 2020
@warner
Copy link
Member Author

warner commented Apr 20, 2020

fixed in #963

@warner warner closed this as completed Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warner warner

Labels
cosmic-swingset package: cosmic-swingset
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@warner