API governance captures governed APIs at initial creation, doesn't notice upgrades #9990
Assignees
Labels
Comments
mergify bot
added a commit
that referenced
this issue
Jan 22, 2025
closes: #9990 ## Description When a contract is upgraded, we'll read the governed APIs afresh. ### Security Considerations Nothing special. The point of governed APIs is that contracts can make access to calling specific APIs legible in the sense used by governance. ### Scaling Considerations Not an issue. ### Documentation Considerations If we had detailed documentation on governance, this would be worth adding to the docs. ### Testing Considerations Added a bootstrap test showing that a contract can be upgraded and the new APIs will be available after upgrade. ### Upgrade Considerations AssetReserve, fluxAggregator, and VaultFactory use `apiGovernance` and might need this support if any governed APIs were added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the Problem Being Solved?
setupApiGovernance()is called with the current set of governed APIs when a contract is first created. If the contract updates the list on an upgrade, the API governor won't notice it.Description of the Design
rather than
We should call
where
getGovernedFoo()should be a function passed through that callsE(creatorFacet).getGovernedApis()orE(creatorFacet).getGovernedApiNames()later.Security Considerations
superior robustness for upgrading contracts.
Scaling Considerations
No consequences.
Test Plan
A test that upgrades contracts.
The text was updated successfully, but these errors were encountered: