feat: add an accessor for the vaultDirector's parameters #10707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
32f1398
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8303c75c.agoric-sdk.pages.dev |
| Branch Preview URL: | https://10094-vaultdirparams.agoric-sdk.pages.dev |
0xpatrickdev
approved these changes
Dec 17, 2024
Chris-Hibbert
added
the
automerge:rebase
Chris-Hibbert
force-pushed
the
10094-vaultDirParams
branch
from
84572e7 to
32f1398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10094
Description
Add a direct way to retrieve the governed parameters from the vaultDirector
Security Considerations
This was already accessible (and intended to be public) via vstorage. It just adds a direct way to request the values when you have the vaultFactory publicFacet.
Scaling Considerations
No effect.
Documentation Considerations
No change
Testing Considerations
Added a Unit test.
Upgrade Considerations
The purpose was to simplify retrieving the previous values for upgrade.