Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap SES shim on xsnap #2194

Merged
merged 6 commits into from
Jan 14, 2021
Merged

bootstrap SES shim on xsnap #2194

merged 6 commits into from
Jan 14, 2021

Conversation

dckc
Copy link
Member

@dckc dckc commented Jan 14, 2021

No description provided.

@dckc dckc requested review from warner and kriskowal January 14, 2021 02:38
kriskowal
kriskowal approved these changes Jan 14, 2021
View reviewed changes
packages/xs-vat-worker/package.json Outdated Show resolved Hide resolved
packages/xsnap/src/xsnap.c Show resolved Hide resolved
packages/xs-vat-worker/test/test-boot-lockdown.js Outdated Show resolved Hide resolved
packages/xs-vat-worker/src/console-shim.js Show resolved Hide resolved
@dckc dckc marked this pull request as ready for review January 14, 2021 03:03
kriskowal
kriskowal reviewed Jan 14, 2021
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@dckc dckc force-pushed the xs-vat-lockdown branch 2 times, most recently from 7b8f701 to 38c6b93 Compare January 14, 2021 03:26
dckc added 5 commits January 13, 2021 21:35
@dckc
chore(xs-vat-worker): prune obsolete code
b3bcd48
@dckc
build(xs-vat-worker): rollup config
98402c5
@dckc
feat(xs-vat-worker): bootstrap SES shim on xsnap
e775a99 
 - add ses dependency
 - noop console, since xsnap no longer provides `print`
 - re-package XS ArrayBuffer.fromString() extension as
   TextEncoder.prototype.encode
 - use `xsStringBuffer()` C API rather than `String.fromArrayBuffer`
   JS API so that xsnap eval continues to work after `lockdown()`.
@dckc
build: sync xsnap package version at 0.1.0
ab30ab7
@dckc
refactor: avoid interpolating code in code
72e0894
warner
warner approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dckc dckc merged commit 5fdaf9d into Agoric:master Jan 14, 2021
@dckc dckc self-assigned this Jan 14, 2021
This was referenced Jan 15, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@dckc dckc mentioned this pull request Jan 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kriskowal kriskowal kriskowal approved these changes

@warner warner warner approved these changes

Assignees

@dckc dckc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dckc @warner @kriskowal