Govern add collateral #3972
Closed
Govern add collateral #3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move makeAddTypeInvitation to a new file, and make an alternate version that doesn't make an AMM. (It doesn't need an invitation) for governance to call
Chris-Hibbert
added
Beta
Core Economy
This comment has been minimized.
This comment has been minimized.
Chris-Hibbert
force-pushed
the
governAddCollateral
branch
from
08d6304 to
618fb32
Compare
The contract can respond to the update on the voting subscription add a test that a new vaultManager was added and can issue loans
Chris-Hibbert
force-pushed
the
governAddCollateral
branch
from
618fb32 to
1263d0f
Compare
This comment has been minimized.
This comment has been minimized.
fixed. Thanks. |
|
The next attempt will be based on API governance. |
|
obviated by #3924 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #3924
Description
Add a new Collateral type to the Treasury as a result of a Governance vote.
This is a first step. More changes coming.
Security Considerations
This is part of contract governance, so it needs to be both secure and legible.
Documentation Considerations
Updates to Treasury doc. Updates about how governed contracts can be informed about chosen changes.
Testing Considerations
thorough and convincing tests, because this is part of governance.