Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract functions in kernel that will be used by dynamic vat creation #409

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

Chris-Hibbert
Copy link
Contributor

@Chris-Hibbert Chris-Hibbert commented Jan 13, 2020

The changes in this PR don't change any behavior

Here, we extract these functions

  • validateVatSetupFn
  • buildVatManager
  • buildDeviceManager
  • assignIdAndBuildVatManager

The base change for the vatAdmin changes is here. See this discussion for context.

…ion.

The changes in this PR don't change any behavior

extract
  validateVatSetupFn
  buildVatManager
  buildDeviceManager
  assignIdAndBuildVatManager
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, nice cleanup

@Chris-Hibbert Chris-Hibbert merged commit aa5e7ab into bugFix Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants