Core-eval governance support #5042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
approved these changes
Apr 8, 2022
| } | ||
|
|
||
| if (board) { | ||
| const bundlerMakerId = await E(board).getId(bundlerMaker); |
There was a problem hiding this comment.
this await is not top level. worth a comment to say that this is not production code? either here or at the top of the file or both?
| import url from 'url'; | ||
|
|
||
| export const makeGetBundlerMaker = | ||
| ({ board, zoe, scratch }, { lookup, bundleSource }) => |
There was a problem hiding this comment.
lack of types obscures the fact that board is optional. hm.
| @@ -0,0 +1,38 @@ | |||
| // @ts-check | |||
There was a problem hiding this comment.
Add a note that this should go away after we have bundlecaps, with a pointer to and from a relevant issue?
michaelfig
force-pushed
the
mfig-core-gov
branch
from
170c44e to
8552696
Compare
michaelfig
added
the
automerge:no-update
... for installing large contracts
- some Makefile support in cosmic-swingset
michaelfig
force-pushed
the
mfig-core-gov
branch
from
92cd66d to
b2b0b5a
Compare
dckc
reviewed
Apr 8, 2022
| stdout.write(trimmed); | ||
| }; | ||
|
|
||
| if (isEntrypoint(import.meta.url)) { |
There was a problem hiding this comment.
interesting approach. isEntrypoint is powerful, but I suppose so was require.main.
A Stackoverflow post has a succinct version:
if (import.meta.url === `file://${process.argv[1]}`) {
// module was not imported but called directly
}
but that's less robust; it's followed by one that uses url.pathToFileURL as in isEntrypoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New features and tests to help make core-eval governance more reproducible.
Security Considerations
Documentation Considerations
Testing Considerations