feat(run-protocol): collect runStake fees #5197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
turadg
force-pushed
the
ta/runStake-collectFees
branch
from
4d425ad to
c9f8eef
Compare
Co-authored-by: Chris Hibbert <[email protected]>
dckc
reviewed
Apr 22, 2022
There was a problem hiding this comment.
I defer to @Chris-Hibbert ; I'm fuzzy on makeGovernorFacet(creatorFacet)
Comment on lines
-207
to
+214
| return { publicFacet, creatorFacet }; | ||
| return { publicFacet, creatorFacet: makeGovernorFacet(creatorFacet) }; |
There was a problem hiding this comment.
Does this mean runStake governance was previously busted? Did we not have any tests for it?
There was a problem hiding this comment.
I just moved the makeGovernorFacet down here to make more obvious that there are two slightly different things named creatorFacet.
|
Darn; I think the permit for that needs tweaking: modified packages/run-protocol/src/core-proposal.js
@@ -137,6 +137,7 @@ const REWARD_MANIFEST = harden({
loadVat: true,
vaultFactoryCreator: true,
ammCreatorFacet: true,
+ // TODO: runStake
zoe: true,
},
produce: {
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
makeCollectFeesInvitationto RunStake's creatorstartRewardDistributorSecurity Considerations
RunStake creator facet exposes a way to collect its fees
fixes: #5004
Documentation Considerations
--
Testing Considerations
Relying on types. Open to requests for additional coverage.