vault security improvements #5440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
commented
May 26, 2022
| @@ -86,7 +67,15 @@ const liquidate = async ( | |||
| ]); | |||
| // NB: all the proceeds from AMM sale are on the vault seat instead of a staging seat | |||
|
|
|||
| const { shortfall, overage } = discrepancy(debt, proceeds.RUN); | |||
| const [overage, shortfall] = AmountMath.isGTE(debt, proceeds.RUN) | |||
There was a problem hiding this comment.
I'm not sure this is better. read better before, imho.
There was a problem hiding this comment.
I might have gone with
const short = AmountMath.isGTE(debt, proceeds.RUN);
const overage = short
? AmountMath.makeEmptyFromAmount(debt)
: AmountMath.subtract(proceeds.RUN, debt);
const shortfall = short
? AmountMath.subtract(debt, proceeds.RUN)
: AmountMath.makeEmptyFromAmount(debt);
I'm not a fan of the trinary assigning two values
turadg
commented
May 26, 2022
| @@ -255,7 +255,16 @@ const helperBehavior = { | |||
| }, | |||
| updateTime, | |||
| ); | |||
| partialAssign(state, stateUpdates); | |||
|
|
|||
| // specify keys defensively | |||
There was a problem hiding this comment.
another way is,
state.compoundedInterest = stateUpdates.compoundedInterest;
(x3)
opinions @dtribble ?
There was a problem hiding this comment.
While use of partialAssign with the 3 explicit fields addresses the risk that changes in the interest computation might change something else, assignments to the individual fields are even more clear which parts of the state can be affected; no need for the reader to check the partialAssign function.
turadg
force-pushed
the
ta/security-tweaks
branch
from
575ab2a to
66fffd9
Compare
|
The PR title here buries the lede considerably. Please change it to something like:
well, I suppose it's not an observable bug fix. So...
|
|
Yeah, not a fix. Does your request to change the PR title have to do with the commit history or something else? I'll be landing this as a merge commit so it's this commit that will appear in the history: refactor(interest): specify keys defensively EDIT: I did while amending it: |
…to interest result
after:
```
gov-collateral › assets are in AMM, Vaults
ℹ && task was past its deadline when scheduled: 0 &&
ℹ @@ schedule task for:86400, currently: 0 @@
ℹ && task was past its deadline when scheduled: 0 &&
ℹ @@ schedule task for:3600, currently: 0 @@
ℹ addAsset {
denom: 'ibc/abc123',
issuer: '[object Alleged: ibc/abc123 issuer]',
keyword: 'ibc/abc123',
}
Rejected promise returned by test. Reason:
Error {
message: 'Must first setReserveDepositFacet',
}
```
before:
```
gov-collateral › assets are in AMM, Vaults
ℹ chainTimerService: new Promise
ℹ zoe: new Promise
ℹ feeMintAccess: new Promise
ℹ agoricNames: new Promise
ℹ agoricNamesAdmin: new Promise
ℹ chainTimerService settled; remaining: [
'agoricNames',
'agoricNamesAdmin',
'feeMintAccess',
'zoe',
]
ℹ zoe settled; remaining: [
'agoricNames',
'agoricNamesAdmin',
'feeMintAccess',
]
ℹ feeMintAccess settled; remaining: [
'agoricNames',
'agoricNamesAdmin',
]
ℹ agoricNames settled; remaining: [
'agoricNamesAdmin',
]
ℹ agoricNamesAdmin settled; remaining: []
ℹ loadVat: new Promise
ℹ restoreBundleID: new Promise
ℹ board: new Promise
ℹ loadVat settled; remaining: [
'board',
'restoreBundleID',
]
ℹ restoreBundleID settled; remaining: [
'board',
]
ℹ bridgeManager: new Promise
ℹ bankManager: new Promise
ℹ initialSupply: new Promise
ℹ bldIssuerKit: new Promise
ℹ client: new Promise
ℹ clientCreator: new Promise
ℹ coreEvalBridgeHandler: new Promise
ℹ bridgeManager settled; remaining: [
'bankManager',
'bldIssuerKit',
'board',
'client',
'clientCreator',
'coreEvalBridgeHandler',
'initialSupply',
]
ℹ bankManager settled; remaining: [
'bldIssuerKit',
'board',
'client',
'clientCreator',
'coreEvalBridgeHandler',
'initialSupply',
]
ℹ clientCreator settled; remaining: [
'bldIssuerKit',
'board',
'client',
'coreEvalBridgeHandler',
'initialSupply',
]
ℹ client settled; remaining: [
'bldIssuerKit',
'board',
'coreEvalBridgeHandler',
'initialSupply',
]
ℹ namesByAddress: new Promise
ℹ namesByAddressAdmin: new Promise
ℹ coreEvalBridgeHandler settled; remaining: [
'bldIssuerKit',
'board',
'initialSupply',
'namesByAddress',
'namesByAddressAdmin',
]
ℹ namesByAddress settled; remaining: [
'bldIssuerKit',
'board',
'initialSupply',
'namesByAddressAdmin',
]
ℹ namesByAddressAdmin settled; remaining: [
'bldIssuerKit',
'board',
'initialSupply',
]
ℹ initialSupply settled; remaining: [
'bldIssuerKit',
'board',
]
ℹ board settled; remaining: [
'bldIssuerKit',
]
ℹ bldIssuerKit settled; remaining: []
ℹ priceAuthorityVat: new Promise
ℹ priceAuthority: new Promise
ℹ priceAuthorityAdmin: new Promise
ℹ priceAuthority settled; remaining: [
'priceAuthorityAdmin',
'priceAuthorityVat',
]
ℹ priceAuthorityAdmin settled; remaining: [
'priceAuthorityVat',
]
ℹ priceAuthorityVat settled; remaining: []
ℹ vaultFactoryCreator: new Promise
ℹ economicCommitteeCreatorFacet: new Promise
ℹ ammCreatorFacet: new Promise
ℹ ammGovernorCreatorFacet: new Promise
ℹ reserveCreatorFacet: new Promise
ℹ reserveGovernorCreatorFacet: new Promise
ℹ reservePublicFacet: new Promise
ℹ lienBridge: new Promise
ℹ runStakeCreatorFacet: new Promise
ℹ runStakeGovernorCreatorFacet: new Promise
ℹ vaultFactoryGovernorCreator: new Promise
ℹ vaultFactoryVoteCreator: new Promise
ℹ economicCommitteeCreatorFacet settled; remaining: [
'ammCreatorFacet',
'ammGovernorCreatorFacet',
'lienBridge',
'reserveCreatorFacet',
'reserveGovernorCreatorFacet',
'reservePublicFacet',
'runStakeCreatorFacet',
'runStakeGovernorCreatorFacet',
'vaultFactoryCreator',
'vaultFactoryGovernorCreator',
'vaultFactoryVoteCreator',
]
ℹ && task was past its deadline when scheduled: 0 &&
ℹ @@ schedule task for:86400, currently: 0 @@
ℹ runStakeGovernorCreatorFacet settled; remaining: [
'ammCreatorFacet',
'ammGovernorCreatorFacet',
'lienBridge',
'reserveCreatorFacet',
'reserveGovernorCreatorFacet',
'reservePublicFacet',
'runStakeCreatorFacet',
'vaultFactoryCreator',
'vaultFactoryGovernorCreator',
'vaultFactoryVoteCreator',
]
ℹ runStakeCreatorFacet settled; remaining: [
'ammCreatorFacet',
'ammGovernorCreatorFacet',
'lienBridge',
'reserveCreatorFacet',
'reserveGovernorCreatorFacet',
'reservePublicFacet',
'vaultFactoryCreator',
'vaultFactoryGovernorCreator',
'vaultFactoryVoteCreator',
]
ℹ ammGovernorCreatorFacet settled; remaining: [
'ammCreatorFacet',
'lienBridge',
'reserveCreatorFacet',
'reserveGovernorCreatorFacet',
'reservePublicFacet',
'vaultFactoryCreator',
'vaultFactoryGovernorCreator',
'vaultFactoryVoteCreator',
]
ℹ ammCreatorFacet settled; remaining: [
'lienBridge',
'reserveCreatorFacet',
'reserveGovernorCreatorFacet',
'reservePublicFacet',
'vaultFactoryCreator',
'vaultFactoryGovernorCreator',
'vaultFactoryVoteCreator',
]
ℹ reserveGovernorCreatorFacet settled; remaining: [
'lienBridge',
'reserveCreatorFacet',
'reservePublicFacet',
'vaultFactoryCreator',
'vaultFactoryGovernorCreator',
'vaultFactoryVoteCreator',
]
ℹ reserveCreatorFacet settled; remaining: [
'lienBridge',
'reservePublicFacet',
'vaultFactoryCreator',
'vaultFactoryGovernorCreator',
'vaultFactoryVoteCreator',
]
ℹ reservePublicFacet settled; remaining: [
'lienBridge',
'vaultFactoryCreator',
'vaultFactoryGovernorCreator',
'vaultFactoryVoteCreator',
]
ℹ vaultFactoryCreator settled; remaining: [
'lienBridge',
'vaultFactoryGovernorCreator',
'vaultFactoryVoteCreator',
]
ℹ vaultFactoryGovernorCreator settled; remaining: [
'lienBridge',
'vaultFactoryVoteCreator',
]
ℹ vaultFactoryVoteCreator settled; remaining: [
'lienBridge',
]
ℹ && task was past its deadline when scheduled: 0 &&
ℹ @@ schedule task for:3600, currently: 0 @@
ℹ addAsset {
denom: 'ibc/abc123',
issuer: '[object Alleged: ibc/abc123 issuer]',
keyword: 'ibc/abc123',
}
Rejected promise returned by test. Reason:
Error {
message: 'Must first setReserveDepositFacet',
}
```
turadg
force-pushed
the
ta/security-tweaks
branch
from
66fffd9 to
848148c
Compare
turadg
added
the
automerge:no-update
dckc
approved these changes
May 27, 2022
| @@ -86,7 +67,15 @@ const liquidate = async ( | |||
| ]); | |||
| // NB: all the proceeds from AMM sale are on the vault seat instead of a staging seat | |||
|
|
|||
| const { shortfall, overage } = discrepancy(debt, proceeds.RUN); | |||
| const [overage, shortfall] = AmountMath.isGTE(debt, proceeds.RUN) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow ups to #5393 (comment)
Security Considerations
Improvements
Documentation Considerations
--
Testing Considerations
No changes.