fix(smart-wallet): invitation issuer is remote

[Chris-Hibbert]

refs: #6084

Description

Dan and I were trying to make progress on voting based on top of #6084, and ran into two issues, but the PR merged before we could suggestion this correction.

missing E() around an invitationIssuer

(I originally included updating decentral-psm-config to use smartwallet, but that's maybe not for master).

Security Considerations

None

Documentation Considerations

None

Testing Considerations

None

[dtribble]

LGTM

[turadg]

Change is okay but I think before merge we should find a way to prevent this error in the future. I can do that if you prefer.

Looks like this type is wrong,

agoric-sdk/packages/zoe/src/zoeService/types.js

Lines 54 to 58 in b120bbb

	/**
	* @callback GetInvitationIssuer
	* @returns {Promise<Issuer>}
	*/

Should be FarRef<Issuer>?

Is there any way to have this fail in Ava without running a full swingset test?

[Chris-Hibbert]

Change is okay but I think before merge we should find a way to prevent this error in the future. I can do that if you prefer.

I removed automerge:. would you prefer to make a new PR?

[turadg]

@Chris-Hibbert fixing the type was a rabbit hole. I think this is good to merge since there's no Ava test and the TS will get fixed over time.

I added back the automerge and made it "squash" to the PR title, which I've updated.