fixes to Economic Governance abilities #6422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
commented
Oct 7, 2022
turadg
commented
Oct 7, 2022
packages/inter-protocol/test/amm/vpool-xyk-amm/test-amm-governance.js
Outdated
Show resolved
Hide resolved
turadg
commented
Oct 7, 2022
| @@ -15,7 +15,7 @@ package "GovernedContract Vat" <<Rectangle>> { | |||
| +terms: { electionManager, governedParams } | |||
| +getState() | |||
| +getContractGovernor() | |||
| -getParamManagerRetriever() | |||
| -getParamMgrRetriever() | |||
There was a problem hiding this comment.
If you make a change to this file, please run .../governance/docs/gen.sh, and checkin the changes to the .png.
turadg
force-pushed
the
fix-replaceElectorate
branch
3 times, most recently
from
25f4382 to
7ff37a4
Compare
Chris-Hibbert
approved these changes
Oct 7, 2022
| @@ -0,0 +1 @@ | |||
| replace committee | |||
| }, | ||
| }; | ||
|
|
||
| // #region Quasi-imports |
There was a problem hiding this comment.
I think this is saying: this section is the result of a poor-man's module system where we manually copy the functions we need from elsewhere in the SDK.
There was a problem hiding this comment.
| return candidate; | ||
| }; | ||
|
|
||
| // #endregion |
There was a problem hiding this comment.
Oh, here's the other end. But I'm still convinced the is leftover copypasta.
| @@ -0,0 +1 @@ | |||
| true | |||
turadg
added
automerge:no-update
turadg
force-pushed
the
fix-replaceElectorate
branch
from
369d290 to
be3b393
Compare
turadg
force-pushed
the
fix-replaceElectorate
branch
from
be3b393 to
14463d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BLD holders must be able to replace a rogue economic committee. #5539 won't be done until MN-1.1 so we need some way for Core Eval to do it in an extreme situation.
Security Considerations
Creates a
.replaceElectoratecapability for holders of aGovernedContractFacetAccess. A group that has access to this already has the ability to vote in a new committee. (Though currently not necessarily the ability to create a new committee as the replacement.)Documentation Considerations
Script demonstrating how its done.
Testing Considerations
Targeted unit test.
Integration test on local chain, with the dapp-econ-gov UI letting a new committee adjust PSM params and pause APIs.