Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added features to priceAggregatorChainlink #6752

Closed
wants to merge 1 commit into from
Closed

added features to priceAggregatorChainlink #6752

wants to merge 1 commit into from

Conversation

jacquesvcritien
Copy link
Contributor

refs: #6629

Description

The following features were added:

  • Added who submitted, when a round was started, and by whom it was started in the round details
  • Changed some variable names
  • Added more prints for easier node operator debugging
  • Added who started the round and who submitted to the vstorage round data to be queried by the middleware

dckc
dckc requested changes Jan 6, 2023
View reviewed changes
packages/inter-protocol/src/priceAggregatorChainlink.js
Comment on lines -665 to +702
* @param {string} oracleId unique per contract instance
* @param {string} oracleAddr Bech32 of oracle operator smart wallet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The caller of this contract may use an address for the oracleId, but the contract doesn't depend on that. See earlier discussion: #6629 (comment)

@turadg turadg mentioned this pull request Jan 6, 2023
Merged
@jacquesvcritien
Copy link
Contributor Author

Closing as

  • Will be adding the round starter in another PR
  • Variable names were reverted
  • Removed prints as debugging is not needed
  • Using wallet offers to check whether an oracle submitted to a round

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dckc dckc dckc requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacquesvcritien @dckc