6707 pause feed #6982
Closed
6707 pause feed #6982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
force-pushed
the
6701-ec-removeOracles
branch
2 times, most recently
from
bcf33fe to
70e196e
Compare
turadg
force-pushed
the
6707-pause-feed
branch
from
9ad2759 to
32b0282
Compare
turadg
force-pushed
the
6701-ec-removeOracles
branch
from
70e196e to
9b6e2cd
Compare
|
should be "closes #6707"? |
|
This design using a governed API relies on the contract to correctly implement pausing, where using invitation description matching is done by Zoe, without cooperation of the contract. I/we should ask around about that a bit... |
turadg
force-pushed
the
6707-pause-feed
branch
from
32b0282 to
1f9ff68
Compare
|
Closing as it's not needed anytime soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #6707
stacks on #6977
Description
Provides EC the power to pause pushes (for all oracles) to a particular feed.
The issue described doing this by adding an identifier in the 'PushPrice' offer string. I opted against that because of,
Security Considerations
Grants EC the power pause price pushes to a feed.
Scaling Considerations
--
Documentation Considerations
Part of EC tooling documentation.
Testing Considerations
New tests. While working in these contract/wallet/governance integration tests I think a driver may be worthwhile. I factored out
voteForOpenQuestionhere and may do more in #6859