refactor(scaledPriceAuthority): initialPrice by composition #7023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
force-pushed
the
dc-pa-initial
branch
6 times, most recently
from
bb317cd to
f1a6fe1
Compare
turadg
approved these changes
Feb 17, 2023
Comment on lines
51
to
66
| const quoteAmount = harden({ | ||
| brand: quoteBrand, | ||
| value: [ | ||
| { | ||
| amountIn, | ||
| amountOut, | ||
| timer, | ||
| timestamp, | ||
| }, | ||
| ], | ||
| }); | ||
| const quotePayment = await E(quoteMint).mintPayment({ | ||
| brand: quoteBrand, | ||
| value: [quoteAmount], | ||
| }); | ||
| return harden({ quoteAmount, quotePayment }); |
There was a problem hiding this comment.
dupes
consider DRYing. fine to have priceAuthorityInitial depend on priceAuthorityTransform so the latter could just export that maker function
There was a problem hiding this comment.
LGTM, especially the mintQuote naming
| }); | ||
| return harden({ quoteAmount, quotePayment }); | ||
| }; | ||
| const initialUpdateP = oneQuote( |
There was a problem hiding this comment.
consider inlining this so the promises don't try to resolve if they're never needed
There was a problem hiding this comment.
I'm pushing it down/in some, but I don't want to do a round trip to the timer service for clients that repeatedly call getUpdateSince() without bumping the updateCount.
dckc
commented
Feb 17, 2023
turadg
approved these changes
Feb 17, 2023
refactor(scaledPriceAuthority): factor out mintQuote() - clarify priceOutPerIn - clarify mintCurrentQuote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #6957, #6960, #7008, #7016
Description
Rather than mucking with the internals of
makePriceAuthorityTransform, compose it with amakeInitialTransform.Security Considerations
more straightforward to audit
Documentation Considerations
makeInitialTransformhas a bit of documentation as to its purpose and function.Testing Considerations
Pure refactor; invisible to unit tests. :)
Tasks