Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(network): networkVat core eval usage; scrub TODOs #8979

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

dckc
Copy link
Member

@dckc dckc commented Feb 23, 2024

closes #8854
refs: #8823

Description

Since the loopback handler is a testing facility, demote the TODOs.

Security / Documentation Considerations

Document networkVat core eval usage expectations.

Scaling / Testing / Upgrade Considerations

n/a

Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dckc dckc added the automerge:rebase Automatically rebase updates, then merge label Feb 27, 2024
Copy link

@dckc - This PR appears to be stuck. It's had a merge label for > 24 hours

Base automatically changed from iomekam-ibc-network-durability to master February 29, 2024 21:16
Copy link

github-actions bot commented Mar 2, 2024

@dckc - This PR appears to be stuck. It's had a merge label for > 24 hours

@mergify mergify bot merged commit fd864a4 into master Mar 2, 2024
65 of 66 checks passed
@mergify mergify bot deleted the dc-net-power-docs branch March 2, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate TODOs in Network Vat
2 participants