Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #24

Closed
wants to merge 18 commits into from
Closed

Develop #24

wants to merge 18 commits into from

Conversation

sidekickr
Copy link
Contributor

This fixes an issue with exact string matches. THere's a bunch of commits that I had tried to rebase, but I didn't quite get it right. 33b46b3 is the commit that matters.

David Siebecker and others added 18 commits October 17, 2016 16:33
Merge remote-tracking branch 'Ahmed-Ali/master' into develop
306e4ec
fixing issue with regex parsing with optional components
0fdd851
@Ahmed-Ali
Updated pod spec
5c5134e
fixing issue with regex parsing with optional components
ee64f75
Merge branch 'develop' of https://github.com/sidekickr/Cucumberish in…
99f9be3 
…to develop
An update to make sure the example test that uses KIF still working w…
1415904 
…ell with Xcode 8

- Ran 'pod install' to update KIF for the latest version to work with Xcode 8.
- Updated the history table accessibility label to avoid confusion with the history button
Update the UI test target to make sure it is working.. Though not all…
98ba75e 
… the steps are implemented in this target
Updated the README.md
1c8df9f
Updated README.md
b09d8a0
@Ahmed-Ali
Update README.md
298f888
Updated podspec file
998e113
Deleted unwanted scheme used only for testing
f41b1e9
Documentation update and deprecate methods
53b67fc
Updated the example app to reflect the new updates
ff63320
@Ahmed-Ali
Update README.md
3809ff0
@Ahmed-Ali
Update README.md
c630703
Updated the project for the UI test target example
08986a0
Merge branch 'develop' of https://github.com/Ahmed-Ali/Cucumberish in…
04b84d3 
…to develop

# Via GitHub
* 'develop' of https://github.com/Ahmed-Ali/Cucumberish:
  Update README.md
  Update README.md
@Ahmed-Ali
Copy link
Owner

Hi @sidekickr
Thanks for active support man, really appreciated!
I will not be able to merge this one as it is so hard to know what has been changed.
Try to:

  • Create a patch for the desired changes and save it locally.
  • Fork the develop branch
  • Apply the patch and create a PR.

@Ahmed-Ali Ahmed-Ali closed this Oct 21, 2016
@sidekickr sidekickr mentioned this pull request Oct 25, 2016
Merged
@sidekickr
Copy link
Contributor Author

Roger, I’ll clean and resubmit.

David

On Oct 21, 2016, at 5:32 PM, Ahmed Ali [email protected] wrote:

Hi @sidekickr https://github.com/sidekickr
Thanks for active support man, really appreciated!
I will not be able to merge this one as it is so hard to know what has been changed.
Try to:

Create a patch for the desired changes and save it locally.
Fork the develop branch
Apply the patch and create a PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #24 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AFrkpwN2qY-pvDxA5_3z-NFFG1QEjgS2ks5q2S90gaJpZM4KdifN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidekickr @Ahmed-Ali