Report failure in beforeStartHook

[brentleyjones]

Currently an assertion failure in any of the hooks will throw an exception and not report a test failure. This change makes them all report test failures (except after finish, which I'll speak to).

Of importance is that if the beforeStartHook fails it will fail all of the scenarios. This is useful since you will normally setup preconditions needed for the rest of your tests in that hook.

The afterFinishHook is not handled the same way, for a couple reasons:

• It's after all of your scenarios, so if they all passed we don't want a test failure
• I don't know what to do if you have a failure there. Not crashing would probably be nice. I don't use this feature though, so I'm not the best one to ask

[Ahmed-Ali]

Hi @brentleyjones
Thanks a lot for your amazing contributions!
I am a bit late in my responses these days (I might remain busy to the end of January).
Once I am able to get more free time, I will check them all one by one and do my best to get all the PRs merged and resolve all the recently opened issues.
Cheers

[brentleyjones]

No problem. Have a good holiday if you are celebrating. We can work with forks for a while.

[Ahmed-Ali]

Thanks Brentley!

[brentleyjones]

@Ahmed-Ali Just checking in on this.

[Ahmed-Ali]

Thanks a lot @brentleyjones for your support and apologizes for the late merge!