-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
68: Support for dry-run to print undefined steps #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review looks good. Do you think you could add some tests for this, so we don't regress on the behavior later (since not everyone will use this feature)?
Sure. Any idea what kind of tests would fit better for this feature? Do you think it makes sense to add tests to the CucumberishTests target for this? |
Yeah, add tests to CucumberishTests target. After that I'll get to this after the 4th of July. Busy at work and then a small vacation. |
67 steps in report
I added some test to the CucumberishFeatureDefinition target because the step definitions form the CucumberTests target are using I had to add a log manager to assert that the logs were properly printed. It might a bit overcomplicated for the task but it does the job. I also had some problem since the steps are not executed when |
Cucumberish/Core/Models/CCIStep.h
Outdated
|
||
/** | ||
@return a string composed of the keyword and the text of the tep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: tep
Thanks @TitouanVanBelle! |
This pull request allow users to use the dry run feature described in #68 the following way
The results are printed in the logs the following way
dryRunLanguage = CCILanguageObjectiveC
dryRunLanguage = CCILanguageSwift
When all steps are defined, the following is printed