Fix tablet and mobile devices and also fix desktop issue #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
syedsaadqamar
commented
Jun 23, 2019
•
syedsaadqamar
commented
- Fix tablet issue -> give false when the device is a tablet
- Fix desktop issue -> show desktop true if device unknown and mobile/tablet
- Fix mobile issue -> some mobile devices gives false like Blackberry Z30
- Improve some code as well
- Fix desktop issue: show desktop true if device unknown and mobile/tablet - Fix mobile issue: some mobile devices gives false like Blackberry Z30
gtteamamxx
suggested changes
Jun 27, 2019
src/device-detector.service.ts
Outdated
| @@ -134,12 +144,16 @@ export class DeviceDetectorService { | |||
| * @returns whether the current device is a desktop device | |||
| */ | |||
| public isDesktop() { | |||
| return [ | |||
| const destopDevices = [ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.