Merge pull request #4435 from TripleWhy/TripleWhy/issue4425

palette effect overflow fix
Aircoookie · Jan 9, 2025 · 709aeff · 709aeff
2 parents 34f1812 + 56e1d57
commit 709aeff
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/wled00/FX.cpp b/wled00/FX.cpp
@@ -2032,7 +2032,7 @@ uint16_t mode_palette() {
       const mathType sourceX = xtSinTheta + ytCosTheta + centerX;
       // The computation was scaled just right so that the result should always be in range [0, maxXOut], but enforce this anyway
       // to account for imprecision. Then scale it so that the range is [0, 255], which we can use with the palette.
-      int colorIndex = (std::min(std::max(sourceX, mathType(0)), maxXOut * sInt16Scale) * 255) / (sInt16Scale * maxXOut);
+      int colorIndex = (std::min(std::max(sourceX, mathType(0)), maxXOut * sInt16Scale) * wideMathType(255)) / (sInt16Scale * maxXOut);
       // inputSize determines by how much we want to scale the palette:
       // values < 128 display a fraction of a palette,
       // values > 128 display multiple palettes.