Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to toggle the reception of palette synchronizations #4137

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Add the ability to toggle the reception of palette synchronizations #4137

merged 2 commits into from
Sep 16, 2024

Conversation

felddy
Copy link
Contributor

@felddy felddy commented Sep 10, 2024

🗣 Description

This PR adds the ability to toggle the reception of palette synchronizations on a node.

  • adds a new global receiveNotificationPalette
  • adds a checkbox for "Palette" to the "Sync Setup" configuration page. (see screenshot)
  • adds request handling of new form checkbox.
  • adds logic to prevent the application of palette changes during synchronization.
  • adds json serialization and deserialization of new configuration item.

Supported issues:

💭 Motivation and context

I want to keep the palette synchronized across all nodes, but need to preserve the effect on some of them.

🧪 Testing

Tested on four ESP32 nodes. Verified palettes can be synchronized without effects, and effects can be synchronized without palettes.

📷 Screenshots (if appropriate)

image

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow [WLED code standards].

@blazoncek
Copy link
Collaborator

FYI palette, not pallet.
Otherwise looks ok to me.

@felddy felddy changed the title Add the ability to toggle the reception of pallet synchronizations Add the ability to toggle the reception of palette synchronizations Sep 10, 2024
@softhack007
Copy link
Collaborator

softhack007 commented Sep 10, 2024

felddy force-pushed the feature/toggle_pallet_sync branch

@felddy please avoid force-pushing github while you have a PR open.
It has all kinds of subtle bad consequences, for example code review comments lost and bugreports being re-opened at random.

@felddy
Copy link
Contributor Author

felddy commented Sep 10, 2024

FYI palette, not pallet. Otherwise looks ok to me.

Doh! 🤦‍♂️
Spelling corrected, and image retested.
Fixed a palette typo in a comment in index.js as well.

@blazoncek blazoncek merged commit 7f1ec48 into Aircoookie:0_15 Sep 16, 2024
3 of 20 checks passed
@felddy felddy deleted the feature/toggle_pallet_sync branch September 16, 2024 19:10
blazoncek added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants