Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes "preset not found" issue when using internal temp UM #4393

Closed

Conversation

lost-hope
Copy link
Collaborator

fixes #4390

this comit fixes the issue reported by user orbitinstasis
Copy link
Collaborator

@softhack007 softhack007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good for me 👍

🤔 Actually I'm still wondering why someone would use a temperature sensor that's so inaccurate for anything like a safety function - but that's another matter.

Just to explain "inaccurate" - I have two esp32 sitting next to each other, doing the same thing. Internal temperature for the first is 50°C, the second shows 78°C. And in reality, both are note even "Luke warm" when I touch the esp32 with my finger. This tells me that the internal temp sensor of esp32 is really a useless toy nothing more.

@orbitinstasis
Copy link

Changes look good for me 👍

🤔 Actually I'm still wondering why someone would use a temperature sensor that's so inaccurate for anything like a safety function - but that's another matter.

Just to explain "inaccurate" - I have two esp32 sitting next to each other, doing the same thing. Internal temperature for the first is 50°C, the second shows 78°C. And in reality, both are note even "Luke warm" when I touch the esp32 with my finger. This tells me that the internal temp sensor of esp32 is really a useless toy nothing more.

I found the bug - the SoC dye is a heck of a lot hotter than the actual carrier board, and I wouldn't really rely on it for a safety feature (for that I use a proper sensor with the dallas usermod), but this mod gives a nice idea of how the ambient temp is affecting the SoC for certain environments say where the electronics is enclosed, you'd want a dye temp and an ambient temp.

@DedeHai
Copy link
Collaborator

DedeHai commented Dec 14, 2024

just FYI, from the docs:
image

the default range is -10°C - 80°C so it should be fairly accurate, if all you need is the die temperature.

@lost-hope lost-hope changed the base branch from 0_15 to main December 14, 2024 18:40
@lost-hope lost-hope changed the base branch from main to 0_15 December 14, 2024 18:40
@lost-hope
Copy link
Collaborator Author

Closing this after talking to @netmindz to make a new PR against main branch.
#4397 is the new one

@lost-hope lost-hope closed this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants