Use consistent node version for local, CI, and devcontainer setup #4424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inverse
force-pushed
the
consistent-node
branch
from
cd266b6 to
97e8382
Compare
|
Do we need to be so specific right down to the patch version? |
|
Can be modified to not include the patch version but would mean more consistent builds. Leveraging tools such as renovate can automate bumping the patch version too. Happy to drop the patch version if you feel it makes more sense for this project. |
|
Yeah if you can drop the patch version please. We don't have the resources to keep on top of patch updates |
inverse
commented
Dec 24, 2024
| @@ -2,12 +2,7 @@ | |||
|
|
|||
| # [Choice] Python version: 3, 3.9, 3.8, 3.7, 3.6 | |||
| ARG VARIANT="3" | |||
| FROM mcr.microsoft.com/vscode/devcontainers/python:0-${VARIANT} | |||
There was a problem hiding this comment.
This container has been deprecated since last year so migrated to the new version
inverse
changed the title
|
@netmindz any further feedback on this one? |
softhack007
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.nvmrcto define node version for the project (20.18).nvmrcfile