clickhouse: allow restoring experimental MergeTree settings #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aris-aiven
force-pushed
the
aris-experimental-settings-restore
branch
from
4abaca9 to
e2098b3
Compare
The two settings were introduced between v23.8 and v24.3. They are needed when restoring by clusters that have defined them at the table level.
aris-aiven
force-pushed
the
aris-experimental-settings-restore
branch
from
e2098b3 to
0d037bc
Compare
Khatskevich
reviewed
Dec 5, 2024
| @@ -685,6 +685,8 @@ def _create_dbs(client: ClickHouseClient) -> Iterator[Awaitable[None]]: | |||
| b"SET allow_hyperscan=true", | |||
| b"SET allow_simdjson=true", | |||
| b"SET allow_deprecated_syntax_for_merge_tree=true", | |||
| b"SET allow_experimental_block_number_column=true", | |||
| b"SET allow_experimental_replacing_merge_with_cleanup=true", | |||
There was a problem hiding this comment.
I do not think this helps. Those are merge tree settings and you are setting them as query level settings. Those settings do not exist and should cause UNKNOWN_SETTING error.
But on the other hand, table settings should have been preserved and should not have caused any error... I do not yet understand it...
There was a problem hiding this comment.
main conversation here https://aiven-io.slack.com/archives/C052RDBD1TP/p1733428433123549
There was a problem hiding this comment.
True, these settings should have been set at the table level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two settings were introduced between v23.8 and v24.3. They are needed when restoring by clusters that have defined them at the table level.