Skip to content

Commit

Permalink
fix: Delete read_raw_bytes (#104)
Browse files Browse the repository at this point in the history
This function is not used.

Closes #94.
  • Loading branch information
aiven-anton authored Dec 11, 2023
1 parent 2f3c5be commit a1cbfcc
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 29 deletions.
7 changes: 0 additions & 7 deletions src/kio/serial/readers.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,6 @@ def read_compact_string_nullable(buffer: IO[bytes]) -> str | None:
return bytes_value.decode()


def read_raw_bytes(buffer: IO[bytes]) -> bytes | None:
length = read_int32(buffer)
if length == 0:
return None
return buffer.read(length - 1)


def read_legacy_bytes(buffer: IO[bytes]) -> bytes:
length = read_int32(buffer)
if length == -1:
Expand Down
22 changes: 0 additions & 22 deletions tests/serial/test_readers.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
from kio.serial.readers import read_legacy_string
from kio.serial.readers import read_nullable_legacy_bytes
from kio.serial.readers import read_nullable_legacy_string
from kio.serial.readers import read_raw_bytes
from kio.serial.readers import read_uint8
from kio.serial.readers import read_uint16
from kio.serial.readers import read_uint32
Expand Down Expand Up @@ -272,27 +271,6 @@ def test_can_read_string_sync(
assert value == read_compact_string_nullable(buffer)


class TestReadRawBytes:
def test_returns_null_for_negative_length_sync(
self,
buffer: io.BytesIO,
) -> None:
buffer.write((0).to_bytes(4, "big"))
buffer.seek(0)
assert read_raw_bytes(buffer) is None

def test_can_read_bytes_sync(
self,
buffer: io.BytesIO,
) -> None:
value = b"k\x9bC\x94\xbe\x1fV\xd6"
byte_length = len(value) + 1 # string length is offset by one
buffer.write(struct.pack(">i", byte_length))
buffer.write(value)
buffer.seek(0)
assert value == read_raw_bytes(buffer)


class TestReadNullableLegacyBytes:
def test_returns_none_for_negative_length_sync(
self,
Expand Down

0 comments on commit a1cbfcc

Please sign in to comment.