Fix broken handling of timestamps, lacking test coverage #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiven-anton
force-pushed
the
fix/incorrect-phantom-type-invocations
branch
from
e32d0e1 to
7915fbd
Compare
giuseppelillo
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some tests breaking on main. I presume recent version of Hypothesis (or possibly just entropy) started generating some more interesting values.
This is also related to:
There are also other tests failing on
maincurrently, AFAICT those are also related to either entropy or some change in how Hypothesis generates data. All those remaining failures are related to records, which are known to not be properly implemented yet #100. I'd prefer to merge this PR separately first, and then look into addressing the failing records tests.