Compare all 64-bits of return values with expected #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alan-Jowett
approved these changes
Aug 18, 2023
hawkinsw
force-pushed
the
64_bit_retval
branch
5 times, most recently
from
d2a01a4 to
b7afe9d
Compare
hawkinsw
force-pushed
the
64_bit_retval
branch
from
b7afe9d to
564684c
Compare
hawkinsw
force-pushed
the
64_bit_retval
branch
11 times, most recently
from
03fb5d7 to
a46c93e
Compare
hawkinsw
force-pushed
the
64_bit_retval
branch
from
a46c93e to
8427f2b
Compare
Alan-Jowett
approved these changes
Aug 30, 2023
Instead of considering only the 32 LSB when comparing the expected return values with the actual return values, consider all 64 bits. Fixes Alan-Jowett#142 Signed-off-by: Will Hawkins <[email protected]>
hawkinsw
force-pushed
the
64_bit_retval
branch
from
8427f2b to
fc7e47b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of considering only the 32 LSB when comparing the expected return values with the actual return values, consider all 64 bits.
Fixes #142