feat(theme): add initial files to support Excursion theme #153 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-capsule42
force-pushed
the
jbaker/themeSupport
branch
4 times, most recently
from
4fc0fa6 to
f1e0eee
Compare
jordanjones243
force-pushed
the
jbaker/themeSupport
branch
from
b4cb92f to
b54d255
Compare
jason-capsule42
commented
May 14, 2024
jason-capsule42
commented
May 14, 2024
jordanjones243
force-pushed
the
jbaker/themeSupport
branch
3 times, most recently
from
afe7db1 to
88b6cb9
Compare
jason-capsule42
force-pushed
the
jbaker/themeSupport
branch
2 times, most recently
from
039c082 to
aa05781
Compare
|
|
jason-capsule42
force-pushed
the
jbaker/themeSupport
branch
from
b24e25f to
3387b1e
Compare
jason-capsule42
force-pushed
the
jbaker/themeSupport
branch
from
3387b1e to
aea9a92
Compare
blackfalcon
requested changes
May 16, 2024
| "comment": "Deprecated token", | ||
| "reference": "n/a", | ||
| "version": "3.12.0" | ||
| "deprecated": true |
There was a problem hiding this comment.
None of the newly deprecated tokens have the additional data required to fill out the 'deprecated tokens' page in the doc site. We should have the following added to each deprecated token.
reference - this is a reference to the new token to be used of there is one designated
version - this is used to communicate with wich release these tokens were listed as deprecated
Changes to be committed: modified: src/color/background.json modified: src/color/base.json modified: src/color/container.json modified: src/color/text.json
This update addresses the readability order of the configs to be more clear when illustrating files that are loaded and which files when loaded will over-ride the previously loaded files. Additionally the excursion and jetstream configs were updated to eliminate the unnecessary over-ride inclusion. Changes to be committed: modified: package.json modified: scripts/config-darkmode.json modified: scripts/config-excursion.json modified: scripts/config-jetstream.json modified: scripts/config.json
blackfalcon
requested changes
May 17, 2024
blackfalcon
force-pushed
the
jbaker/themeSupport
branch
from
db933cc to
3c66201
Compare
6 tasks
Changes to be committed: modified: src/color/background.json modified: src/color/border.json modified: src/color/container.json modified: src/color/icon.json modified: src/color/text.json
jordanjones243
force-pushed
the
jbaker/themeSupport
branch
from
3c66201 to
f24b2ab
Compare
jordanjones243
requested changes
May 20, 2024
| @@ -151,15 +151,15 @@ | |||
| }, | |||
| "error": { | |||
| "default": { | |||
| "value": "{color.base.error.100.value}", | |||
| "value": "{color.state.error.100.value}", | |||
There was a problem hiding this comment.
According to this file, we should be using base not state:
| "public": true, | ||
| "neutral": true, | ||
| "usage": "", | ||
| "wcag": "n/a", | ||
| "deprecated": false | ||
| }, | ||
| "inverse": { | ||
| "value": "{color.base.error.500.value}", | ||
| "value": "{color.state.error.500.value}", |
There was a problem hiding this comment.
Revert all state changes back to error
jordanjones243
requested changes
May 20, 2024
| "reference": "color-brand-neutral-500", | ||
| "comment": "{comments.reference.comment} color-brand-neutral-500" | ||
| "reference": "color-brand-grey-500", | ||
| "comment": "{comments.reference.comment} color-brand-grey-500" | ||
| } | ||
| } | ||
| }, | ||
| "state": { |
There was a problem hiding this comment.
According to figma, state tokens should be deprecated and there should be new base tokens
| @@ -2,150 +2,346 @@ | |||
| "color": { | |||
There was a problem hiding this comment.
base-black and base-white tokens are now on the 100s scale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #153
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team