Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate legacy .is-touch selector reference #192

Open
blackfalcon opened this issue Apr 25, 2024 · 0 comments
Open

Deprecate legacy .is-touch selector reference #192

blackfalcon opened this issue Apr 25, 2024 · 0 comments

Comments

@blackfalcon
Copy link
Member

General Support Request

See the following code

@if $env == component {
:host(:not(.is-touching)) & {
&:hover {
cursor: pointer;
text-decoration: underline;
color: $hover-color;
}
}
} @else if $env == noncomponent {
@media (hover: hover) {
&:hover {
cursor: pointer;
text-decoration: underline;
color: $hover-color;
}
}
} @else {
@error 'Invalid $env option. Please use `component` or `noncomponent`';
}

The selector :host(:not(.is-touching)) & is no longer supported by any component.

Possible Solution

Deprecate this functionality and set for removal with next MAJOR release.

Additional context

This was discovered with recent updates to the auro-hyperlink element AlaskaAirlines/auro-hyperlink#205

Exit criteria

This issue can be resolved once the identified code is set as DEPRECATED and slotted for removal with the next release.

blackfalcon added a commit to AlaskaAirlines/auro-hyperlink that referenced this issue Apr 25, 2024
This commit updates all the legacy .is-touch selector references, that
was deprecated a while ago, to use the preferred @media hover query.

@include auro_anchorButton was also updated to use the `noncomponent`
API option. While this is inconsistent with intended use, the
`component` value of the API calls in the legacy .is-touch reference
that is no longer supported.

This is discussed in the following WCSS issue
AlaskaAirlines/WebCoreStyleSheets#192

Changes to be committed:
modified:   src/component-base.mjs
modified:   src/style.scss
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Apr 29, 2024
blackfalcon added a commit to AlaskaAirlines/auro-hyperlink that referenced this issue May 7, 2024
This commit updates all the legacy .is-touch selector references, that
was deprecated a while ago, to use the preferred @media hover query.

@include auro_anchorButton was also updated to use the `noncomponent`
API option. While this is inconsistent with intended use, the
`component` value of the API calls in the legacy .is-touch reference
that is no longer supported.

This is discussed in the following WCSS issue
AlaskaAirlines/WebCoreStyleSheets#192

Changes to be committed:
modified:   src/component-base.mjs
modified:   src/style.scss
blackfalcon added a commit to AlaskaAirlines/auro-hyperlink that referenced this issue May 7, 2024
This commit updates all the legacy .is-touch selector references, that
was deprecated a while ago, to use the preferred @media hover query.

@include auro_anchorButton was also updated to use the `noncomponent`
API option. While this is inconsistent with intended use, the
`component` value of the API calls in the legacy .is-touch reference
that is no longer supported.

This is discussed in the following WCSS issue
AlaskaAirlines/WebCoreStyleSheets#192

Changes to be committed:
modified:   src/component-base.mjs
modified:   src/style.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants