Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Node 18 #33

Closed
blackfalcon opened this issue May 25, 2023 · 0 comments · Fixed by #38
Closed

Update to Node 18 #33

blackfalcon opened this issue May 25, 2023 · 0 comments · Fixed by #38
Assignees
@irma-kurnia-alaska
Labels
auro-alert Status: Work In Progress Issue or Pull Request work is in Progress
Milestone
Alert: Node 18+ U...

Comments

@blackfalcon
Copy link
Member

Is your feature request related to a problem? Please describe.

Repo is structured to only support Node 16.

Describe the solution you'd like

Update to support Node 18.

https://github.com/AlaskaAirlines/auro-flight/blob/50854e9213f571c6137303fa466a7ea9a3df944a/package.json#L18-L20

https://github.com/AlaskaAirlines/auro-flight/blob/50854e9213f571c6137303fa466a7ea9a3df944a/.github/workflows/testPublish.yml#L18

https://github.com/AlaskaAirlines/auro-flight/blob/50854e9213f571c6137303fa466a7ea9a3df944a/.github/workflows/testPublish.yml#L40

Update all action dependencies to v3

https://github.com/AlaskaAirlines/auro-flight/blob/50854e9213f571c6137303fa466a7ea9a3df944a/.github/workflows/testPublish.yml#L21-L43

Exit criteria

This issue is complete once all the code references have been updated to support Node 18 and the latest dependency versions.

This issue was copied from #58 by @blackfalcon.
@blackfalcon blackfalcon added Status: Work In Progress Issue or Pull Request work is in Progress Type: perf labels May 25, 2023
@blackfalcon blackfalcon transferred this issue from AlaskaAirlines/auro-flight May 25, 2023
@blackfalcon blackfalcon added auro-alert and removed Status: Work In Progress Issue or Pull Request work is in Progress labels May 25, 2023
@blackfalcon blackfalcon added this to the Node 18+ Update milestone May 25, 2023
@irma-kurnia-alaska irma-kurnia-alaska self-assigned this May 26, 2023
@irma-kurnia-alaska irma-kurnia-alaska added the Status: Work In Progress Issue or Pull Request work is in Progress label May 26, 2023
irma-kurnia-alaska pushed a commit that referenced this issue May 29, 2023
@irma-kurnia-phtn
perf: update to node 18 #33
971275b 
Change to be committed:
modified: package-lock.json
modified: package.json
modified: .github/workflows/testPublish.yml
modified: /test/auro-alert.test.js
@irma-kurnia-alaska irma-kurnia-alaska mentioned this issue May 30, 2023
Merged
3 tasks
@irma-kurnia-alaska irma-kurnia-alaska linked a pull request May 30, 2023 that will close this issue
Update Node 18 #38
Merged
3 tasks
blackfalcon pushed a commit that referenced this issue Jun 29, 2023
@irma-kurnia-phtn @blackfalcon
perf: update to node 18 #33
216ab80 
Change to be committed:
modified: package-lock.json
modified: package.json
modified: .github/workflows/testPublish.yml
modified: /test/auro-alert.test.js
blackfalcon pushed a commit that referenced this issue Jun 29, 2023
@semantic-release-bot
chore(release): 2.0.4 [skip ci]
d799d8a 
## [2.0.4](v2.0.3...v2.0.4) (2023-06-29)

### Performance Improvements

* **deps:** remove unsed dependencies from project ([ab67636](ab67636))
* fix general feedback ([1c70c07](1c70c07))
* remove legacy es5 bundling resources [#31](#31) ([6c5b43a](6c5b43a))
* update to Lit2.0, TS support, issue templates, component registration extension [#32](#32) and update all depedencies legacy [#34](#34) ([c52ee38](c52ee38))
* update to node 18 [#33](#33) ([216ab80](216ab80))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irma-kurnia-alaska irma-kurnia-alaska

Labels
auro-alert Status: Work In Progress Issue or Pull Request work is in Progress
Projects
None yet
Milestone
Alert: Node 18+ Updates
Development

Successfully merging a pull request may close this issue.

Update Node 18 AlaskaAirlines/auro-alert
2 participants
@blackfalcon @irma-kurnia-alaska