Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): complete rebuild of component #8

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Jul 14, 2023

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #7, #10

Summary:

Complete rewrite of the original auro-labs component for official release.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jason-capsule42 jason-capsule42 self-assigned this Jul 14, 2023
@jason-capsule42 jason-capsule42 linked an issue Jul 14, 2023 that may be closed by this pull request
@jason-capsule42 jason-capsule42 force-pushed the jbaker/modernize branch 2 times, most recently from bb4e30c to 393748e Compare July 14, 2023 21:41
@github-actions
Copy link

github-actions bot commented Jul 14, 2023

Surge demo deployment succeeded! 🚀🚀🚀

Auro Web Component Generator

@leeejune
Copy link

@jason-capsule42 Everything looks great! Here are my comments:

  1. Are we able to add animation on the page when it scrolls up? (slow scroll instead of jumping straight to the top)
  2. It'd be great to add the other style (blue outlined style like our secondary button) under the "Example(s)" section.

@jason-capsule42
Copy link
Member Author

Per team decision, this PR will be released without resolving this ticket first: #9

@jason-capsule42
Copy link
Member Author

@jason-capsule42 Everything looks great! Here are my comments:

  1. Are we able to add animation on the page when it scrolls up? (slow scroll instead of jumping straight to the top)

Technically possibly. There are two ways to do it. You can adjust the scroll behavior of the entire site to have a "smooth" affect but this impacts a heck of a lot more than just the backtotop component. You can also do it with keyframe animation but this adds a bunch of heavy javascript into the component. (https://stackoverflow.com/questions/46068631/animate-scrollleft-of-a-container-from-point-a-to-b/46072227#46072227).

I don't think the first solution is something appropriate for us to do and I think the second solution is a lot heavier than the value the animation contributes to the experience.

  1. It'd be great to add the other style (blue outlined style like our secondary button) under the "Example(s)" section.

The secondary style is displayed on the api demo page. Just add /api.html to the surge demo url

@jason-capsule42 jason-capsule42 marked this pull request as ready for review July 20, 2023 19:14
@leeejune
Copy link

leeejune commented Jul 20, 2023

Out of curiosity, what are the drawbacks/impact of having heavier javascript in the component?

This heavy JS based animation may be non-performant on slower machines or machines that are running under heavy load. In those cases the animation could look choppy.

Also, the JS required to animate this particular affect is not trivial and adds some complexity to sustaining support of the component. That's not necessary a reason in itself to not write the code, but it's worth calling it out as part of a conversation as to if the value outweighs the cost of doing it.

Given the risk of poor performance in certain scenarios combined with the code complexity, I'd argue that this small animation may not be worth it.

The secondary style is displayed on the api demo page. Just add /api.html to the surge demo url

For some reason it won't show up for me.

Looks like there is a problem with the tool that builds the surge demo when it comes to the API page. Seems to only be doign the main page correctly. You will have to pull the repo and run it locally until we fix that script in the mean time.

demo/api.html Outdated Show resolved Hide resolved
src/auro-backtotop.js Outdated Show resolved Hide resolved
src/auro-backtotop.js Outdated Show resolved Hide resolved
Copy link
Contributor

@jordanjones243 jordanjones243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a number of dependencies that need to be updated.

Screen Shot 2023-07-21 at 11 11 59 AM

test/auro-backtotop.test.js Show resolved Hide resolved
demo/demo.md Show resolved Hide resolved
docs/partials/demo.md Outdated Show resolved Hide resolved
docs/upstream.md Show resolved Hide resolved
@jason-capsule42 jason-capsule42 force-pushed the jbaker/modernize branch 3 times, most recently from a500293 to 0d45ae2 Compare July 21, 2023 19:17
@braven112
Copy link
Member

We should be able to handle the scrolling animation on the page layouts that will use this component so its not necessary to add it to the component at this time.

@leeejune
Copy link

@jason-capsule42 Are we able to add a white background under the hover state color?
Screenshot 2023-07-21 at 4 02 21 PM

The hover color would ideally be layered over a white solid color.

@jason-capsule42
Copy link
Member Author

@jason-capsule42 Are we able to add a white background under the hover state color? Screenshot 2023-07-21 at 4 02 21 PM

The hover color would ideally be layered over a white solid color.

@leeejune these styles are pulled from the secondary style of auro-button. We would need to make this change there. Do you want to open a ticket for that change?

@leeejune
Copy link

leeejune commented Jul 24, 2023

These styles are pulled from the secondary style of auro-button. We would need to make this change there. Do you want to open a ticket for that change?

@jason-capsule42 I opened a ticket here: AlaskaAirlines/auro-button#227

This change will be done prior to other work remaining in back-to-top.

.travis.yml Show resolved Hide resolved
src/auro-backtotop.js Show resolved Hide resolved
docTemplates/README.md Outdated Show resolved Hide resolved
docs/partials/index.md Outdated Show resolved Hide resolved
apiExamples/pageContent.html Outdated Show resolved Hide resolved
apiExamples/pageContent.html Outdated Show resolved Hide resolved
src/auro-backtotop.js Show resolved Hide resolved
src/auro-backtotop.js Show resolved Hide resolved
src/style.scss Outdated Show resolved Hide resolved
src/style.scss Outdated Show resolved Hide resolved
@jason-capsule42 jason-capsule42 force-pushed the jbaker/modernize branch 3 times, most recently from 7c9168a to d1651a7 Compare July 29, 2023 04:07
src/auro-backtotop.js Outdated Show resolved Hide resolved
Copy link
Member

@blackfalcon blackfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tokens for this repo have been updated. This repo is still set to PRIVATE and needs to be made public prior to release.

Also, there are no references to BREAKING CHANGES in the commits, this release WILL NOT create the MAJOR release that is required for this work.

@jason-capsule42 jason-capsule42 force-pushed the jbaker/modernize branch 2 times, most recently from ccbc528 to 87ca946 Compare August 4, 2023 17:27
Copy link
Member

@blackfalcon blackfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo is set to PIVATE. Needs to be changed to PUBLIC prior to release.

Also, please update the commit message to meet the team's agreed specifications using an imperative mood. E.g. ... [commit message header]

Please take a look at this article that outlines the team's expectations.

demo/index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@jordanjones243 jordanjones243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2023-08-07 at 3 42 25 PM

A few updates needed to packages

demo/api.html Outdated Show resolved Hide resolved
BREAKING CHANGE: namespace changed to @AuroDesignSystem
jordanjones243
jordanjones243 previously approved these changes Aug 8, 2023
@blackfalcon blackfalcon linked an issue Aug 8, 2023 that may be closed by this pull request
@Patrick-Daly-AA
Copy link

We addressed issue #10 in retrospective today. The plan is that June will pull down and assess the impact of this behavior, and if it is judged acceptable for the time being, we will merge this to main, but keep it off of the DocSite, and address the issue in a quick follow up

@jason-capsule42 jason-capsule42 merged commit c6f2be6 into main Aug 9, 2023
@blackfalcon
Copy link
Member

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Aug 9, 2023
@blackfalcon blackfalcon deleted the jbaker/modernize branch August 9, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BACK TO TOP appears as soon as the UI scrolls 1px Upgrade whole element repo
7 participants