-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): complete rebuild of component #8
Conversation
bb4e30c
to
393748e
Compare
Surge demo deployment succeeded! 🚀🚀🚀 |
@jason-capsule42 Everything looks great! Here are my comments:
|
Per team decision, this PR will be released without resolving this ticket first: #9 |
Technically possibly. There are two ways to do it. You can adjust the scroll behavior of the entire site to have a "smooth" affect but this impacts a heck of a lot more than just the backtotop component. You can also do it with keyframe animation but this adds a bunch of heavy javascript into the component. (https://stackoverflow.com/questions/46068631/animate-scrollleft-of-a-container-from-point-a-to-b/46072227#46072227). I don't think the first solution is something appropriate for us to do and I think the second solution is a lot heavier than the value the animation contributes to the experience.
The secondary style is displayed on the api demo page. Just add /api.html to the surge demo url |
This heavy JS based animation may be non-performant on slower machines or machines that are running under heavy load. In those cases the animation could look choppy. Also, the JS required to animate this particular affect is not trivial and adds some complexity to sustaining support of the component. That's not necessary a reason in itself to not write the code, but it's worth calling it out as part of a conversation as to if the value outweighs the cost of doing it. Given the risk of poor performance in certain scenarios combined with the code complexity, I'd argue that this small animation may not be worth it.
Looks like there is a problem with the tool that builds the surge demo when it comes to the API page. Seems to only be doign the main page correctly. You will have to pull the repo and run it locally until we fix that script in the mean time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a500293
to
0d45ae2
Compare
We should be able to handle the scrolling animation on the page layouts that will use this component so its not necessary to add it to the component at this time. |
0d45ae2
to
7d01f4f
Compare
@jason-capsule42 Are we able to add a white background under the hover state color? The hover color would ideally be layered over a white solid color. |
@leeejune these styles are pulled from the secondary style of auro-button. We would need to make this change there. Do you want to open a ticket for that change? |
@jason-capsule42 I opened a ticket here: AlaskaAirlines/auro-button#227 This change will be done prior to other work remaining in back-to-top. |
7c9168a
to
d1651a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tokens for this repo have been updated. This repo is still set to PRIVATE and needs to be made public prior to release.
Also, there are no references to BREAKING CHANGES in the commits, this release WILL NOT create the MAJOR release that is required for this work.
ccbc528
to
87ca946
Compare
87ca946
to
61a9cd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repo is set to PIVATE. Needs to be changed to PUBLIC prior to release.
Also, please update the commit message to meet the team's agreed specifications using an imperative mood. E.g. ... [commit message header]
Please take a look at this article that outlines the team's expectations.
61a9cd1
to
1caaf57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BREAKING CHANGE: namespace changed to @AuroDesignSystem
1caaf57
to
49dc361
Compare
We addressed issue #10 in retrospective today. The plan is that June will pull down and assess the impact of this behavior, and if it is judged acceptable for the time being, we will merge this to main, but keep it off of the DocSite, and address the issue in a quick follow up |
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #7, #10
Summary:
Complete rewrite of the original auro-labs component for official release.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team