-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BACK TO TOP appears as soon as the UI scrolls 1px #10
Labels
Comments
blackfalcon
changed the title
The code you have displays the BACK TO TOP button as soon as the UI scrolls 1px. Is that desired? Typically you see a button like this appear when the user scrolls part way down the page.
BACK TO TOP appears as soon as the UI scrolls 1px
Aug 7, 2023
6 tasks
Meeting with @leeejune and she has agreed to review the demo more closely and make recommendations post that review of this work in progress. |
6 tasks
jason-capsule42
assigned jason-capsule42 and unassigned blackfalcon, leeejune and Patrick-Daly-AA
Aug 9, 2023
Per review with @leeejune the scroll position for when to show the button will be changed to 400px. |
jason-capsule42
added a commit
that referenced
this issue
Aug 9, 2023
jason-capsule42
added a commit
that referenced
this issue
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
We could set a higher value on line 115 and then set
lastKnownScrollPostion
to LESS THANtopOfPageYPos
.Or.. we could calculate the total height of the page and then use a percentage of the page to set when the button appears. There is a great example on CSS-Tricks https://css-tricks.com/how-i-put-the-scroll-percentage-in-the-browser-title-bar/
Originally posted by @blackfalcon in #8 (comment)
Describe the solution you'd like
I'd like to review the current assessment of the scrolling feature and understand its decision and discuss why this is different from what is commonly used across the internet.
Exit criteria
Review and discuss options. Create new issues if needed for code/design updates
The text was updated successfully, but these errors were encountered: