Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-badge: remove demo styles #34

Closed
blackfalcon opened this issue Mar 21, 2023 · 0 comments · Fixed by #45
Closed

auro-badge: remove demo styles #34

blackfalcon opened this issue Mar 21, 2023 · 0 comments · Fixed by #45
Assignees
@blackfalcon
Labels
Type: Refactoring A code change that neither fixes a bug nor adds a feature
Milestone
Badge: Node 18+ s...

Comments

@blackfalcon
Copy link
Member

Is your feature request related to a problem? Please describe.

The current repo still references local Sass resources for styling. This has been moved to the Generator repo and can be referenced via CDN.

Describe the solution you'd like

Update the index.html file in the ./dir to use CDN style resources. The local demo Sass resources should be deleted. The npm script for processing these demo styles should also be released.

Exit criteria

This issue will be considered complete once all local demo-style resources and npm scripts related to the processing of these Sass files are removed from the project and the demo page renders as expected from the CDN resources.
@blackfalcon blackfalcon added Type: Refactoring A code change that neither fixes a bug nor adds a feature auro-badge labels Mar 21, 2023
@blackfalcon blackfalcon added this to the Badge: Node 18+ support milestone Mar 21, 2023
@blackfalcon blackfalcon changed the title auro-badge: Remove demo styles auro-badge: remove demo styles Mar 21, 2023
@blackfalcon blackfalcon self-assigned this Mar 22, 2023
@blackfalcon blackfalcon linked a pull request Apr 6, 2023 that will close this issue
Node 18+ updates #45
Merged
6 tasks
@blackfalcon blackfalcon mentioned this issue Apr 6, 2023
Merged
6 tasks
blackfalcon added a commit that referenced this issue Apr 6, 2023
@blackfalcon
perf(demo styles): remove local dependency #34
61abf70 
This commit removes all local demo style Sass resources
and updates gitignore references.

Changes to be committed:
modified:   .gitignore
modified:   demo/index.html
deleted:    demo/sass/style.scss
modified:   package.json
blackfalcon added a commit that referenced this issue Apr 6, 2023
@blackfalcon
perf(demo styles): remove local dependency #34
d0809f3 
This commit removes all local demo style Sass resources
and updates gitignore references.

Changes to be committed:
modified:   .gitignore
modified:   demo/index.html
deleted:    demo/sass/style.scss
modified:   package.json
blackfalcon added a commit that referenced this issue Apr 7, 2023
@blackfalcon
perf(demo styles): remove local dependency #34
f14fe3c 
This commit removes all local demo style Sass resources
and updates gitignore references.

Changes to be committed:
modified:   .gitignore
modified:   demo/index.html
deleted:    demo/sass/style.scss
modified:   package.json
blackfalcon added a commit that referenced this issue Apr 9, 2023
@blackfalcon
perf(demo styles): remove local dependency #34
af0090d 
This commit removes all local demo style Sass resources
and updates gitignore references.

Changes to be committed:
modified:   .gitignore
modified:   demo/index.html
deleted:    demo/sass/style.scss
modified:   package.json
@blackfalcon blackfalcon mentioned this issue Apr 9, 2023
Closed
blackfalcon added a commit that referenced this issue Apr 13, 2023
@blackfalcon
perf(demo styles): remove local dependency #34
8d3dc13 
This commit removes all local demo style Sass resources
and updates gitignore references.

Changes to be committed:
modified:   .gitignore
modified:   demo/index.html
deleted:    demo/sass/style.scss
modified:   package.json
blackfalcon pushed a commit that referenced this issue Apr 13, 2023
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
61190a7 
# [2.0.0](v1.2.4...v2.0.0) (2023-04-13)

### Documentation

* **npm:** update npm namespace [#37](#37) ([ebe7baa](ebe7baa))

### Features

* **ts:** add support for typescript users [#39](#39) ([6d960f0](6d960f0))

### Performance Improvements

* **demo styles:** remove local dependency [#34](#34) ([8d3dc13](8d3dc13))
* **es5:** remove legacy bundle build process [#35](#35) ([5166da4](5166da4))
* **extend:** move customElements.define function to root [#44](#44) ([44ad8c8](44ad8c8))
* **husky:** update to current version [#43](#43) ([f14f563](f14f563))
* **lit:** update component to Lit2.0 [#32](#32) ([2dbf150](2dbf150))
* **node18:** update repo to support Node 18+ [#31](#31) ([8617c36](8617c36))
* **postCss:** remove legacy build services [#40](#40) ([651fcb7](651fcb7))
* **sass:** update to dart-sass [#42](#42) ([d8f40ff](d8f40ff))
* **server:** update to use single shell [#33](#33) ([181aba8](181aba8))

### BREAKING CHANGES

* **npm:** This update will redefine the npm namespace
for the auro-badge element.

Changes to be committed:
modified:   README.md
modified:   package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
Type: Refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
Badge: Node 18+ support
Development

Successfully merging a pull request may close this issue.

Node 18+ updates AlaskaAirlines/auro-badge
1 participant
@blackfalcon