Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update component registration logic #70

Closed
sun-mota opened this issue Oct 17, 2024 · 0 comments · Fixed by #71
Closed

Update component registration logic #70

sun-mota opened this issue Oct 17, 2024 · 0 comments · Fixed by #71
Assignees
@sun-mota
Labels
auro-banner not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes

Comments

@sun-mota
Copy link
Contributor

Please verify the version of auro-banner you have installed

No response

Please describe the bug

Default import of index.js should register the default custom element only.

import of the component class should not register the custom element at all.

Remove all registration of custom-${component name} from the JS and only register as part of ./demo/index.js

Reproducing the error

None

Expected behavior

No response

What browsers are you seeing the problem on?

No response

Additional context

No response

Exit criteria

No response
@sun-mota sun-mota added not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes auro-banner labels Oct 17, 2024
@sun-mota sun-mota self-assigned this Oct 17, 2024
sun-mota added a commit that referenced this issue Oct 22, 2024
@sun-mota
feat(api): add register static method #70
5880da8 
- `AuroBanner.register` is to easily register the element without extra importing
- `import "@aurodesignsystem/auro-banner"` will still register this element to <auro-banner>
- `import { AuroBanner } from '@aurodesignsystem/auro-banner/src/auro-banner.js` wont register this element until `AuroBanner.register` gets called
@sun-mota sun-mota mentioned this issue Oct 22, 2024
Merged
6 tasks
@sun-mota sun-mota linked a pull request Oct 22, 2024 that will close this issue
feat(api): add register static method #70 #71
Merged
6 tasks
sun-mota added a commit that referenced this issue Oct 23, 2024
@sun-mota
feat(api): add register static method #70
a3ffbd2 
- `AuroBanner.register` is to easily register the element without extra importing
- `import "@aurodesignsystem/auro-banner"` will still register this element to <auro-banner>
- `import { AuroBanner } from '@aurodesignsystem/auro-banner/src/auro-banner.js` wont register this element until `AuroBanner.register` gets called
blackfalcon pushed a commit that referenced this issue Oct 23, 2024
@semantic-release-bot
chore(release): 3.1.0 [skip ci]
2af56b9 
# [3.1.0](v3.0.1...v3.1.0) (2024-10-23)

### Features

* **api:** add register static method [#70](#70) ([a3ffbd2](a3ffbd2))

### Performance Improvements

* update dependency versions ([82b19cf](82b19cf))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sun-mota sun-mota

Labels
auro-banner not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api): add register static method #70 AlaskaAirlines/auro-banner
2 participants
@sun-mota @Patrick-Daly-AA