-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MULTI-GITTER PR: migration github-config-and-gitignore-changes #74
MULTI-GITTER PR: migration github-config-and-gitignore-changes #74
Conversation
…thub workflow files
Reviewer's Guide by SourceryThis PR implements several repository configuration changes and documentation updates. The changes primarily focus on standardizing GitHub repository settings, updating contribution guidelines, and improving the documentation structure. The PR also removes demo-related files and adds a new GitHub workflow for demo deployment. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rmenner - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please explain the rationale for removing the demo files (api.md, api.min.js, index.md, index.min.js). Are these being replaced by something else or are they no longer needed?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Surge demo deployment failed! 😭 |
🎉 This PR is included in version 3.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary by Sourcery
Revise GitHub configuration files to improve contribution guidelines, update CI workflows, and introduce a new deployment workflow for demo environments.
CI:
Deployment:
Documentation: