Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add background to onDark secondary button #156

Closed
leeejune opened this issue Apr 7, 2022 · 2 comments · Fixed by #210
Closed

Add background to onDark secondary button #156

leeejune opened this issue Apr 7, 2022 · 2 comments · Fixed by #210
Assignees
@blackfalcon
Labels
auro-button Type: Feature New Feature
Milestone
Node 18+ update

Comments

@leeejune
Copy link
Contributor

leeejune commented Apr 7, 2022

Is your feature request related to a problem? Please describe.

The background on the onDark secondary button is transparent. This makes buttons placed on photos inaccessible.

Describe the solution you'd like

Add a dark background to the onDark secondary button. Changes proposed on the blueprint: https://www.figma.com/file/CFVIEQkpeykfQejPppBili/Button?node-id=322%3A813
@leeejune leeejune added the Type: Feature New Feature label Apr 7, 2022
@blackfalcon blackfalcon assigned leeejune and unassigned blackfalcon Apr 7, 2022
@blackfalcon
Copy link
Member

@leeejune you want to make this update?

@leeejune
Copy link
Contributor Author

leeejune commented Apr 8, 2022

@blackfalcon Sure!

@blackfalcon blackfalcon added this to the auro-button v7.0-rc milestone Jun 3, 2022
@blackfalcon blackfalcon added the not-reviewed Issue has not been reviewed by Auro team members label Jan 20, 2023
@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label Apr 24, 2023
@blackfalcon blackfalcon self-assigned this Apr 28, 2023
blackfalcon added a commit that referenced this issue May 19, 2023
@blackfalcon
feat(ondark): update background values #156
ae2c0e8 
This commit address an issue related to updated color spec
for the button when placed on dark backgrounds.

See design spec:
https://www.figma.com/file/CFVIEQkpeykfQejPppBili/Button?type=design&node-id=322-813&t=FqowZrMG1mtW6O1z-0

Changes to be committed:
modified:   src/style.scss
@blackfalcon blackfalcon linked a pull request May 19, 2023 that will close this issue
Node 18+ support updates #210
Merged
6 tasks
blackfalcon added a commit that referenced this issue May 19, 2023
@blackfalcon
feat(ondark): update background values #156
bdadc29 
This commit address an issue related to updated color spec
for the button when placed on dark backgrounds.

See design spec:
https://www.figma.com/file/CFVIEQkpeykfQejPppBili/Button?type=design&node-id=322-813&t=FqowZrMG1mtW6O1z-0

Changes to be committed:
modified:   src/style.scss
@blackfalcon blackfalcon mentioned this issue May 19, 2023
Merged
6 tasks
blackfalcon added a commit that referenced this issue Jun 1, 2023
@blackfalcon
feat(ondark): update background values #156
eb56ed8 
This commit address an issue related to updated color spec
for the button when placed on dark backgrounds.

See design spec:
https://www.figma.com/file/CFVIEQkpeykfQejPppBili/Button?type=design&node-id=322-813&t=FqowZrMG1mtW6O1z-0

Changes to be committed:
modified:   src/style.scss
blackfalcon added a commit that referenced this issue Jun 6, 2023
@blackfalcon
feat(ondark): update background values #156
b6ef5f8 
This commit address an issue related to updated color spec
for the button when placed on dark backgrounds.

See design spec:
https://www.figma.com/file/CFVIEQkpeykfQejPppBili/Button?type=design&node-id=322-813&t=FqowZrMG1mtW6O1z-0

Changes to be committed:
modified:   src/style.scss
AuroDesignSystem pushed a commit that referenced this issue Jun 6, 2023
@semantic-release-bot
chore(release): 7.0.0 [skip ci]
2e7e17b 
# [7.0.0](v6.6.0...v7.0.0) (2023-06-06)

### Code Refactoring

* **es5:** remove legacy features and build support [#204](#204) ([c0348c4](c0348c4))
* **id:** remove internal ID support [#130](#130) ([1d8d16c](1d8d16c))

### Features

* add multiple updates [#206](#206) ([449c0c4](449c0c4))
* **enum:** add variants support [#160](#160) ([05509b8](05509b8))
* **ondark:** update background values [#156](#156) ([b6ef5f8](b6ef5f8))

### Performance Improvements

* **focus-visible:** remove support for polyfill [#208](#208) ([5f0f8d1](5f0f8d1))
* **icon:** remove internal icon placement support [#209](#209) ([eec81f6](eec81f6))

### BREAKING CHANGES

* This commit includes an update to the
npm namespace to @AuroDesignSystem.

Changes to be committed:
new file:   .github/CODEOWNERS
deleted:    .github/ISSUE_TEMPLATE/audit.md
deleted:    .github/ISSUE_TEMPLATE/bug_report.md
new file:   .github/ISSUE_TEMPLATE/bug_report.yml
deleted:    .github/ISSUE_TEMPLATE/develop-design-story.md
deleted:    .github/ISSUE_TEMPLATE/feature_request.md
new file:   .github/ISSUE_TEMPLATE/feature_request.yml
deleted:    .github/ISSUE_TEMPLATE/general-support.md
new file:   .github/ISSUE_TEMPLATE/general-support.yml
deleted:    .github/ISSUE_TEMPLATE/new_wc.md
deleted:    .github/ISSUE_TEMPLATE/parent-design-story.md
deleted:    .github/ISSUE_TEMPLATE/review-design-story.md
deleted:    .github/ISSUE_TEMPLATE/symbol-design-story.md
deleted:    .github/ISSUE_TEMPLATE/user-story.md
modified:   .github/settings.yml
modified:   .github/workflows/testPublish.yml
modified:   .gitignore
new file:   .husky/pre-commit
modified:   .npmignore
modified:   index.js
deleted:    karma.conf.js
modified:   package-lock.json
* **icon:** This commit will remove all legacy support
for placement of icons within the element other than supporting
icons as slotted content.

Changes to be committed:
modified:   docs/api.md
modified:   src/auro-button.js
modified:   src/style.scss
* **id:** This commit will remove all support for
ID attribute reflection from the parent element to the inner
button element.

Changes to be committed:
modified:   src/auro-button.js
modified:   test/auro-button.test.js
modified:   packageScripts/postinstall.js
* **es5:** This commit removes all legacy es6 build process
including light-dom support, fixed CSS, non CSS variable support,
and es5 bundling.

Changes to be committed:
modified:   README.md
deleted:    babel.config.js
deleted:    demo/alert.js
modified:   demo/demo.md
modified:   demo/index.html
deleted:    demo/sass/style.scss
deleted:    index.html
modified:   package-lock.json
modified:   package.json
modified:   packageScripts/postinstall.js
modified:   rollup.config.js
modified:   scripts/postCss.js
deleted:    scripts/removeNonRemPlugin.js
deleted:    src/auro-button-light.js
modified:   src/auro-button.js
deleted:    src/es5.js
deleted:    src/style-fixed.scss
deleted:    src/style-ld.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackfalcon blackfalcon

Labels
auro-button Type: Feature New Feature
Projects
None yet
Milestone
Node 18+ update
Development

Successfully merging a pull request may close this issue.

Node 18+ support updates AlaskaAirlines/auro-button
2 participants
@blackfalcon @leeejune