Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-button: Focus outlines missing on Windows High Contrast mode #89

Closed
geoffrich opened this issue Nov 10, 2020 · 3 comments · Fixed by #91
Closed

auro-button: Focus outlines missing on Windows High Contrast mode #89

geoffrich opened this issue Nov 10, 2020 · 3 comments · Fixed by #91
Assignees
@geoffrich
Labels
released Completed work has been released Type: Bug Bug or Bug fixes

Comments

@geoffrich
Copy link
Contributor

Describe the bug

When Windows High Contrast Mode is enabled, focus outlines are not shown when tabbing.

image

I believe this is because WHCM ignores border or background color changes and box shadows for focus states.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Firefox

Additional context

I think we should update the default focus styles in WCSS and inherit the changes here.
@geoffrich geoffrich added the Type: Bug Bug or Bug fixes label Nov 10, 2020
@geoffrich geoffrich self-assigned this Nov 10, 2020
@geoffrich geoffrich mentioned this issue Nov 10, 2020
Merged
3 tasks
@geoffrich
Copy link
Contributor Author

FWIW, this mainly seems to be a Firefox issue. Edge seems to apply a focus outline automatically:

image

@blackfalcon
Copy link
Member

blackfalcon commented Nov 16, 2020 •
edited
Loading

Think it would be best if the same solution used in AlaskaAirlines/auro-radio#8 was used here or did AlaskaAirlines/WebCoreStyleSheets#58 address this here?

geoffrich added a commit that referenced this issue Nov 19, 2020
@geoffrich
fix: #89 add missing HCM focus outline
abd35a4
@geoffrich geoffrich mentioned this issue Nov 19, 2020
Merged
3 tasks
blackfalcon pushed a commit that referenced this issue Nov 20, 2020
@geoffrich @blackfalcon
fix: #89 add missing HCM focus outline
e070f42
AuroDesignSystem pushed a commit that referenced this issue Nov 20, 2020
@semantic-release-bot
chore(release): 5.3.1 [skip ci]
e9f6df5 
## [5.3.1](v5.3.0...v5.3.1) (2020-11-20)

### Bug Fixes

* [#89](#89) add missing HCM focus outline ([e070f42](e070f42))
* update to 3.0 core packages ([37704b4](37704b4))
@AuroDesignSystem
Copy link
Collaborator

🎉 This issue has been resolved in version 5.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AuroDesignSystem AuroDesignSystem added the released Completed work has been released label Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoffrich geoffrich

Labels
released Completed work has been released Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #89 add missing HCM focus outline AlaskaAirlines/auro-button
3 participants
@blackfalcon @geoffrich @AuroDesignSystem