Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(themes): update styles to support component themes #243 #251

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented May 29, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #243

Summary:

Rebuild all color styles to support the new Tier 3 standard.

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

Verification

  • No linter issues
  • All automated tests pass
  • New Tier 3 component token exists
  • API Page "Theme" section is valid

DEFAULT

  • default variant renders correctly
  • secondary variant renders correctly
  • tertiary variant renders correctly
  • All variant hover states
  • All variant active states
  • All variant focus states
  • All variant `disabled states

INVERSE

  • default variant renders correctly
  • secondary variant renders correctly
  • tertiary variant renders correctly
  • All variant hover states
  • All variant active states
  • All variant focus states
  • All variant `disabled states

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jason-capsule42 jason-capsule42 self-assigned this May 29, 2024
@jason-capsule42 jason-capsule42 linked an issue May 29, 2024 that may be closed by this pull request
6 tasks
Copy link

github-actions bot commented May 29, 2024

Surge demo deployment failed! 😭

@jason-capsule42 jason-capsule42 force-pushed the jbaker/themeSupport branch 8 times, most recently from 6e9bb5e to 366faed Compare May 30, 2024 04:17
@jason-capsule42 jason-capsule42 marked this pull request as ready for review May 30, 2024 04:27
@jason-capsule42 jason-capsule42 requested a review from a team as a code owner May 30, 2024 04:27
Copy link
Contributor

@jordanjones243 jordanjones243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ondark secondary button seems to be the wrong color on index page (add on dark styles)
  • ondark disabled secondary and tertiary dont look correct to design on index page (add on dark styles)
  • Loader looks vertically off-centered within the button

src/tokens.scss Show resolved Hide resolved
src/tokens.scss Show resolved Hide resolved
src/tokens.scss Show resolved Hide resolved
src/tokens.scss Outdated Show resolved Hide resolved
src/style.scss Outdated Show resolved Hide resolved
src/tokens.scss Outdated Show resolved Hide resolved
src/colors.scss Show resolved Hide resolved
src/colors.scss Show resolved Hide resolved
Copy link
Contributor

@jordanjones243 jordanjones243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add linting updates to this PR

Copy link
Contributor

@jordanjones243 jordanjones243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A build needs to be ran, as there are doc changes that come up

@jason-capsule42 jason-capsule42 force-pushed the jbaker/themeSupport branch 4 times, most recently from 8c38f9c to 461c621 Compare July 2, 2024 19:46
@jason-capsule42 jason-capsule42 changed the base branch from master to beta July 2, 2024 21:24
Copy link
Contributor

@jordanjones243 jordanjones243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • A build still needs to be ran, as doc changes come up when doing so
  • The script that compiles the scss files needs to be updated. When running a sweep, ci then build an error comes up because those files were never compiled

@jason-capsule42 jason-capsule42 force-pushed the jbaker/themeSupport branch 2 times, most recently from 1045f27 to bf5ce49 Compare July 2, 2024 23:21
src/style.scss Outdated Show resolved Hide resolved
@jason-capsule42 jason-capsule42 merged commit 18c1610 into beta Jul 3, 2024
4 checks passed
@jason-capsule42 jason-capsule42 deleted the jbaker/themeSupport branch July 3, 2024 16:51
@blackfalcon
Copy link
Member

🎉 This PR is included in version 7.3.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auro-button: tier 2 & 3 tokens needed
3 participants