-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(themes): update styles to support component themes #243 #251
Conversation
Surge demo deployment failed! 😭 |
6e9bb5e
to
366faed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ondark
secondary button seems to be the wrong color on index page (add on dark styles)ondark disabled
secondary and tertiary dont look correct to design on index page (add on dark styles)- Loader looks vertically off-centered within the button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add linting updates to this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A build needs to be ran, as there are doc changes that come up
8c38f9c
to
461c621
Compare
3843c63
to
3a3bc9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- A build still needs to be ran, as doc changes come up when doing so
- The script that compiles the scss files needs to be updated. When running a
sweep
,ci
thenbuild
an error comes up because those files were never compiled
3a3bc9e
to
e33d277
Compare
1045f27
to
bf5ce49
Compare
bf5ce49
to
bdd5d25
Compare
bdd5d25
to
96cff13
Compare
…were moved to variants
96cff13
to
a810aaf
Compare
🎉 This PR is included in version 7.3.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #243
Summary:
Rebuild all color styles to support the new Tier 3 standard.
Type of change:
Please delete options that are not relevant.
Checklist:
Verification
DEFAULT
default
variant renders correctlysecondary
variant renders correctlytertiary
variant renders correctlyhover
statesactive
statesfocus
statesINVERSE
default
variant renders correctlysecondary
variant renders correctlytertiary
variant renders correctlyhover
statesactive
statesfocus
statesBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team