Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AURO-MIGRATION: Update dependencies to support latest node version(s) #87

Merged
merged 1 commit into from
Feb 28, 2025
Merged

AURO-MIGRATION: Update dependencies to support latest node version(s) #87

merged 1 commit into from
Feb 28, 2025

Conversation

DukeFerdinand
Copy link
Collaborator

@DukeFerdinand DukeFerdinand commented Feb 28, 2025 •
edited by sourcery-ai bot
Loading

Resolves AlaskaAirlines/auro-cli#37 by updating eslint config to latest version (uses node >=18 for LTS support).

Summary by Sourcery

Enhancements:

  • Update dependencies to the latest versions.

@DukeFerdinand
feat!: move peer dependencies to "real" dependencies
ecca9e4 
BREAKING CHANGE: last change was breaking _on a patch version_ because of peer dependencies

Summary:
  Our current build process relies on peer dependencies being present, but
  the peer dependency pipeline is causing far more issues than it's worth.
  Why not just make them regular dependencies? This is what this PR does :)
@DukeFerdinand DukeFerdinand requested a review from a team as a code owner February 28, 2025 20:33
@DukeFerdinand DukeFerdinand self-assigned this Feb 28, 2025
@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Feb 28, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request updates the project's dependencies to support the latest Node.js versions. It includes updates to @aurodesignsystem/auro-hyperlink, @aurodesignsystem/auro-library, @aurodesignsystem/webcorestylesheets, @aurodesignsystem/design-tokens, and @aurodesignsystem/eslint-config. The supported Node.js versions in package.json have been updated to allow versions ^20.x or ^22.x. Additionally, the hyperlink version in src/hyperlinkVersion.js has been updated.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated dependencies to align with the latest standards and features.
  • Updated @aurodesignsystem/auro-hyperlink from 4.2.4 to 5.0.0.
  • Updated @aurodesignsystem/auro-library from 3.0.2 to 3.0.11.
  • Updated @aurodesignsystem/webcorestylesheets from 6.0.2 to 6.1.0.
  • Updated @aurodesignsystem/design-tokens from 4.13.0 to 5.0.2.
  • Updated @aurodesignsystem/eslint-config from 1.3.3 to 1.3.4.
 package.json
package-lock.json
Updated the supported Node.js versions in package.json.
  • Modified the engines.node field to allow versions ^20.x or ^22.x.
 package.json
Updated the hyperlink version in src/hyperlinkVersion.js.
  • Updated the default export to 5.0.0.
 src/hyperlinkVersion.js
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions GitHub Actions
Copy link

Surge demo deployment failed! 😭

sourcery-ai[bot]
sourcery-ai bot reviewed Feb 28, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DukeFerdinand - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using ranges instead of exact versions for peer dependencies to provide more flexibility.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@DukeFerdinand DukeFerdinand merged commit 87bc059 into main Feb 28, 2025
6 of 7 checks passed
@DukeFerdinand DukeFerdinand deleted the dhook/2025_02_27_move_peerdeps_to_dependencies branch February 28, 2025 20:39
@blackfalcon
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@rmenner rmenner rmenner approved these changes

Assignees

@DukeFerdinand DukeFerdinand

Labels
released Completed work has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auro-cli remove auro peerdeps from auro components
3 participants
@DukeFerdinand @blackfalcon @rmenner